From: Nathan Chancellor <nathan@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH 2/2] net: ax88796c: Remove pointless check in ax88796c_open()
Date: Mon, 25 Oct 2021 14:12:39 -0700 [thread overview]
Message-ID: <20211025211238.178768-2-nathan@kernel.org> (raw)
In-Reply-To: <20211025211238.178768-1-nathan@kernel.org>
Clang warns:
drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of
array 'ax_local->phydev->advertising' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
if (ax_local->phydev->advertising &&
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~
advertising cannot be NULL here if ax_local is not NULL, which cannot
happen due to the check in ax88796c_probe(). Remove the check.
Link: https://github.com/ClangBuiltLinux/linux/issues/1492
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/net/ethernet/asix/ax88796c_main.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
index cf0f96f93f3b..528a0c43540b 100644
--- a/drivers/net/ethernet/asix/ax88796c_main.c
+++ b/drivers/net/ethernet/asix/ax88796c_main.c
@@ -850,11 +850,10 @@ ax88796c_open(struct net_device *ndev)
/* Setup flow-control configuration */
phy_support_asym_pause(ax_local->phydev);
- if (ax_local->phydev->advertising &&
- (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
- ax_local->phydev->advertising) ||
- linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
- ax_local->phydev->advertising)))
+ if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
+ ax_local->phydev->advertising) ||
+ linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
+ ax_local->phydev->advertising))
fc |= AX_FC_ANEG;
fc |= linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
--
2.33.1.637.gf443b226ca
next prev parent reply other threads:[~2021-10-25 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 21:12 [PATCH 1/2] net: ax88796c: Fix clang -Wimplicit-fallthrough in ax88796c_set_mac() Nathan Chancellor
2021-10-25 21:12 ` Nathan Chancellor [this message]
2021-10-26 14:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025211238.178768-2-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).