From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B84C433EF for ; Tue, 26 Oct 2021 11:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB5A460238 for ; Tue, 26 Oct 2021 11:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235489AbhJZLUH (ORCPT ); Tue, 26 Oct 2021 07:20:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59630 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235478AbhJZLUG (ORCPT ); Tue, 26 Oct 2021 07:20:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635247062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6TpfncIbRN2wIiXvPAEkb8bm0utZs2Zbi5cSQ14Wg50=; b=c4qL+8cDE+a+2ZFwRH8D0uluY1IsZ5AqA0aofw0AUb5Kp/rxIHRvgQmAzhQAb8FVICv3pd iM5ScFgAMBZZMUVIbcYvQdycDc+VEMONqgxwH8ZNOlaiIT+mnntHeG+Z4uqLAReAtGO1m3 K65hzH4AJyJqUX0brXi1T5Nj8deHRAs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-HNqHZ6ckP1aAckKY_KuSQA-1; Tue, 26 Oct 2021 07:17:41 -0400 X-MC-Unique: HNqHZ6ckP1aAckKY_KuSQA-1 Received: by mail-ed1-f69.google.com with SMTP id z1-20020a05640235c100b003dcf0fbfbd8so12734157edc.6 for ; Tue, 26 Oct 2021 04:17:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6TpfncIbRN2wIiXvPAEkb8bm0utZs2Zbi5cSQ14Wg50=; b=lcpPyCdn4V/TKfTQE+Noi/DRVNzLAFU6DQ7RkMDng8+VtQ5xUYOxjOD610KU8NaRAL BTueqYW2tBvTZ0xqlM22AyK3vzizudpspq1HMaUTrGaYmBLMjetZm/mTLKhebA0w/QSU PSWt8JgxuBfIjbEjl/+ZQzsHViAQLSZyrJ+bNSrYzbJTdvHbnYdlUAL0ReW+M+j4qOgn 8TdvEZqE0JET1jFTjxue/EGSk+N+gQ8buHpy6w3Kn+YID4CZ7sTmDeJ6Xtx9g0wF6VWw IPKqtpTF4sX/J1JhZ1/eJsglYzS5fWlvXANBojC0WmZNK/k2wqHV8S3qqw9bjHzTtd1a ihsA== X-Gm-Message-State: AOAM5322DlX5SmWN8lBV1f7nwoF6dAGWAFohXdSexhYfzO2haqHyLZ2D Ij+mPug+EeMmCuSAUQQzZwWyFV2pu2vMXSyGsx33pdznUvPYghqkF8K1KEXMzyixEdVX5e4ypdR n/bo/0yZ+EiX+cjAw X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr29939023ejy.465.1635247060106; Tue, 26 Oct 2021 04:17:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgsgVHMqjVtNfTJQc71/3yQjNJBw7QbsfzzaH84DrM2rc/AHDvL+5r/1luGk4wkGrC9g125w== X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr29939009ejy.465.1635247059966; Tue, 26 Oct 2021 04:17:39 -0700 (PDT) Received: from steredhat (host-79-30-88-77.retail.telecomitalia.it. [79.30.88.77]) by smtp.gmail.com with ESMTPSA id p23sm11379803edw.94.2021.10.26.04.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 04:17:39 -0700 (PDT) Date: Tue, 26 Oct 2021 13:17:37 +0200 From: Stefano Garzarella To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org Subject: Re: [PATCH 05/10] virtio/vsock: add copy_peercred() to virtio_transport Message-ID: <20211026111737.eyzvbthmc7h3em5z@steredhat> References: <20211021123714.1125384-1-marcandre.lureau@redhat.com> <20211021123714.1125384-6-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211021123714.1125384-6-marcandre.lureau@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Oct 21, 2021 at 04:37:09PM +0400, Marc-André Lureau wrote: >Signed-off-by: Marc-André Lureau >--- > include/linux/virtio_vsock.h | 2 ++ > net/vmw_vsock/virtio_transport_common.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > >diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h >index 35d7eedb5e8e..2445bece9216 100644 >--- a/include/linux/virtio_vsock.h >+++ b/include/linux/virtio_vsock.h >@@ -69,6 +69,8 @@ struct virtio_transport { > > /* Takes ownership of the packet */ > int (*send_pkt)(struct virtio_vsock_pkt *pkt); >+ /* Set peercreds on socket created after listen recv */ >+ void (*copy_peercred)(struct sock *sk, struct virtio_vsock_pkt *pkt); > }; > > ssize_t >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 59ee1be5a6dd..611d25e80723 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -1194,6 +1194,15 @@ virtio_transport_recv_listen(struct sock *sk, struct virtio_vsock_pkt *pkt, > return -ENOMEM; > } > >+ if (t->copy_peercred) { >+ t->copy_peercred(child, pkt); >+ } else { >+ put_pid(child->sk_peer_pid); >+ child->sk_peer_pid = NULL; >+ put_cred(child->sk_peer_cred); >+ child->sk_peer_cred = NULL; >+ } >+ Should we do the same also on the other side? I mean in virtio_transport_recv_connecting() when VIRTIO_VSOCK_OP_RESPONSE is received. I think we can add an helper and call it every time we call vsock_insert_connected(). Even better if we can do it in the core, but maybe this can be a next step. Thanks, Stefano