From: Jiri Wiesner <jwiesner@suse.de>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Mel Gorman <mgorman@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Linux-Net <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] clocksource: increase watchdog retries
Date: Thu, 28 Oct 2021 18:20:25 +0200 [thread overview]
Message-ID: <20211028162025.GA1068@incl> (raw)
In-Reply-To: <20211027213829.GB880162@paulmck-ThinkPad-P17-Gen-1>
On Wed, Oct 27, 2021 at 02:38:29PM -0700, Paul E. McKenney wrote:
> I had something like this pending, but people came up with other workloads
> that resulted in repeated delays. In those cases, it does not make sense
> to ever mark the affected clocksource unstable. This led me to the patch
> shown below, which splats after about 100 consecutive long-delay retries,
> but which avoids marking the clocksource unstable. This is queued on -rcu.
>
> Does this work for you?
>
> commit 9ec2a03bbf4bee3d9fbc02a402dee36efafc5a2d
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date: Thu May 27 11:03:28 2021 -0700
>
> clocksource: Forgive repeated long-latency watchdog clocksource reads
Yes, it does. I have done 100 reboots of the testing machine (running 5.15-rc5 with the above patch applied) and TSC was stable every time. I am going to start a longer test of 300 reboots for good measure and report back next week. J.
next prev parent reply other threads:[~2021-10-28 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 16:43 [RFC PATCH] clocksource: increase watchdog retries Jiri Wiesner
2021-10-27 21:38 ` Paul E. McKenney
2021-10-28 16:20 ` Jiri Wiesner [this message]
2021-10-28 18:42 ` Paul E. McKenney
2021-11-01 10:28 ` Jiri Wiesner
2021-11-02 0:09 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028162025.GA1068@incl \
--to=jwiesner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).