From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: Jiri Pirko <jiri@resnulli.us>, Leon Romanovsky <leon@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
edwin.peer@broadcom.com
Subject: Re: [PATCH net-next] devlink: Require devlink lock during device reload
Date: Mon, 1 Nov 2021 16:11:22 -0700 [thread overview]
Message-ID: <20211101161122.37fbb99d@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <YYBTg4nW2BIVadYE@shredder>
On Mon, 1 Nov 2021 22:52:19 +0200 Ido Schimmel wrote:
> > >Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> >
> > Looks fine to me.
> >
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>
> Traces from mlxsw / netdevsim below:
Thanks a lot for the testing Ido!
Would you mind giving my RFC a spin as well on your syzbot machinery?
Any input on the three discussion points there?
(1) should we have a "locked" and "unlocked" API or use lock nesting?
(2) should we expose devlink lock so that drivers can use devlink
as a framework for their locking needs?
(3) should we let drivers take refs on the devlink instance?
next prev parent reply other threads:[~2021-11-01 23:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 17:35 [PATCH net-next] devlink: Require devlink lock during device reload Leon Romanovsky
2021-11-01 7:12 ` Ido Schimmel
2021-11-01 15:03 ` Jiri Pirko
2021-11-01 20:52 ` Ido Schimmel
2021-11-01 23:11 ` Jakub Kicinski [this message]
2021-11-07 17:16 ` Ido Schimmel
2021-11-07 17:54 ` Leon Romanovsky
2021-11-08 16:09 ` Jakub Kicinski
2021-11-08 17:32 ` Leon Romanovsky
2021-11-08 18:16 ` Jakub Kicinski
2021-11-08 18:24 ` Leon Romanovsky
2021-11-08 18:46 ` Jakub Kicinski
2021-11-08 19:58 ` Leon Romanovsky
2021-11-08 23:31 ` Jakub Kicinski
2021-11-09 14:12 ` Leon Romanovsky
2021-11-09 14:17 ` Jakub Kicinski
2021-11-09 14:30 ` Leon Romanovsky
2021-11-09 14:49 ` Jakub Kicinski
2021-11-09 16:29 ` Jiri Pirko
2021-11-09 14:43 ` Jason Gunthorpe
2021-11-09 15:07 ` Jakub Kicinski
2021-11-09 15:33 ` Jason Gunthorpe
2021-11-09 16:20 ` Jakub Kicinski
2021-11-09 18:24 ` Jason Gunthorpe
2021-11-11 12:05 ` Jiri Pirko
2021-11-11 12:17 ` Leon Romanovsky
2021-11-12 7:38 ` Jiri Pirko
2021-11-14 6:19 ` Leon Romanovsky
2021-11-15 11:20 ` Jiri Pirko
2021-11-15 12:53 ` Jason Gunthorpe
2021-11-15 14:42 ` Jiri Pirko
2021-11-15 15:09 ` Jason Gunthorpe
2021-11-15 15:22 ` Jakub Kicinski
2021-11-16 7:00 ` Jiri Pirko
2021-11-16 13:45 ` Jakub Kicinski
2021-11-16 6:57 ` Jiri Pirko
2021-11-16 12:44 ` Jason Gunthorpe
2021-11-17 14:15 ` Leon Romanovsky
2021-11-10 7:52 ` Leon Romanovsky
2021-11-09 16:15 ` Jiri Pirko
2021-11-09 16:26 ` Jakub Kicinski
2021-11-09 16:30 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101161122.37fbb99d@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=idosch@idosch.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox