* [PATCH] octeontx2-pf: select CONFIG_NET_DEVLINK
@ 2021-11-04 13:34 Arnd Bergmann
2021-11-05 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-11-04 13:34 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Sunil Goutham, Subbaraya Sundeep
Cc: Arnd Bergmann, George Cherian, Vladimir Oltean, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The octeontx2 pf nic driver failsz to link when the devlink support
is not reachable:
aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_get':
otx2_devlink.c:(.text+0x10): undefined reference to `devlink_priv'
aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_validate':
otx2_devlink.c:(.text+0x50): undefined reference to `devlink_priv'
aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_set':
otx2_devlink.c:(.text+0xd0): undefined reference to `devlink_priv'
aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_devlink_info_get':
otx2_devlink.c:(.text+0x150): undefined reference to `devlink_priv'
This is already selected by the admin function driver, but not the
actual nic, which might be built-in when the af driver is not.
Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/Kconfig b/drivers/net/ethernet/marvell/octeontx2/Kconfig
index 3f982ccf2c85..639893d87055 100644
--- a/drivers/net/ethernet/marvell/octeontx2/Kconfig
+++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig
@@ -31,6 +31,7 @@ config NDC_DIS_DYNAMIC_CACHING
config OCTEONTX2_PF
tristate "Marvell OcteonTX2 NIC Physical Function driver"
select OCTEONTX2_MBOX
+ select NET_DEVLINK
depends on (64BIT && COMPILE_TEST) || ARM64
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] octeontx2-pf: select CONFIG_NET_DEVLINK
2021-11-04 13:34 [PATCH] octeontx2-pf: select CONFIG_NET_DEVLINK Arnd Bergmann
@ 2021-11-05 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-05 10:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: davem, kuba, sgoutham, sbhatta, arnd, george.cherian,
vladimir.oltean, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 4 Nov 2021 14:34:42 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The octeontx2 pf nic driver failsz to link when the devlink support
> is not reachable:
>
> aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_get':
> otx2_devlink.c:(.text+0x10): undefined reference to `devlink_priv'
> aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_validate':
> otx2_devlink.c:(.text+0x50): undefined reference to `devlink_priv'
> aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_dl_mcam_count_set':
> otx2_devlink.c:(.text+0xd0): undefined reference to `devlink_priv'
> aarch64-linux-ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: in function `otx2_devlink_info_get':
> otx2_devlink.c:(.text+0x150): undefined reference to `devlink_priv'
>
> [...]
Here is the summary with links:
- octeontx2-pf: select CONFIG_NET_DEVLINK
https://git.kernel.org/netdev/net/c/9cbc3367968d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-05 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 13:34 [PATCH] octeontx2-pf: select CONFIG_NET_DEVLINK Arnd Bergmann
2021-11-05 10:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).