From: Anssi Hannula <anssi.hannula@bitwise.fi>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, Phil Sutter <phil@nwl.cc>,
Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Subject: [PATCH iproute2] man: tc-u32: Fix page to match new firstfrag behavior
Date: Thu, 4 Nov 2021 16:42:05 +0200 [thread overview]
Message-ID: <20211104144203.3581611-1-anssi.hannula@bitwise.fi> (raw)
Commit 690b11f4a6b8 ("tc: u32: Fix firstfrag filter.") applied in 2012
changed the "ip firstfrag" selector to not match non-fragmented packets
anymore.
However, the documentation added in f15a23966fff ("tc: add a man page
for u32 filter") in 2015 includes an example that relies on the previous
behavior (non-fragmented packet counted as first fragment).
Due to this, the example does not work correctly and does not actually
classify regular SSH packets.
Modify the example to use a raw u16 selector on the fragment offset to
make it work, and also make the firstfrag description more clear about
the current behavior.
Fixes: f15a23966fff ("tc: add a man page for u32 filter")
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: Phil Sutter <phil@nwl.cc>
Cc: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
---
I suspect the original behavior was intentional, but the new one has
been out for 9 years now so I guess it is too late to change again.
man/man8/tc-u32.8 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/man8/tc-u32.8 b/man/man8/tc-u32.8
index fec9af7f..507589bd 100644
--- a/man/man8/tc-u32.8
+++ b/man/man8/tc-u32.8
@@ -427,7 +427,7 @@ Also minimal header size for IPv4 and lack of IPv6 extension headers is assumed.
IPv4 only, check certain flags and fragment offset values. Match if the packet
is not a fragment
.RB ( nofrag ),
-the first fragment
+the first fragment of a fragmented packet
.RB ( firstfrag ),
if Don't Fragment
.RB ( df )
@@ -644,7 +644,7 @@ tc filter add dev eth0 parent 1:0 protocol ip \\
tc filter add dev eth0 parent 1:0 protocol ip \\
u32 ht 800: \\
match ip protocol 6 FF \\
- match ip firstfrag \\
+ match u16 0 1fff at 6 \\
offset at 0 mask 0f00 shift 6 \\
link 1:
.EE
--
2.31.1
next reply other threads:[~2021-11-04 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 14:42 Anssi Hannula [this message]
2021-11-04 16:06 ` [PATCH iproute2] man: tc-u32: Fix page to match new firstfrag behavior Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104144203.3581611-1-anssi.hannula@bitwise.fi \
--to=anssi.hannula@bitwise.fi \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=shimoda.hiroaki@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).