From: "Marek Behún" <kabel@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10
Date: Thu, 4 Nov 2021 19:58:28 +0100 [thread overview]
Message-ID: <20211104195828.199c58b9@thinkpad> (raw)
In-Reply-To: <YYQjXVsLTRsTBBHa@shell.armlinux.org.uk>
On Thu, 4 Nov 2021 18:15:57 +0000
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> On Thu, Nov 04, 2021 at 06:17:47PM +0100, Marek Behún wrote:
> > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are
> > only 1G.
>
> Interesting. The original commit says:
>
> SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one
> SERDES is capable of more than 1g; USXGMII is not yet supported
> with this change)
>
> which is ambiguously worded - so I guess we now know that it's only
> port 10 that supports speeds above 1G.
Yes, I just found this info in datasheet.
> Can ports 0 / 1 / 10 be changed at runtime (iow, is the C_Mode field
> writable on these ports?)
Yes, cmode is writable on these ports. serdes.c also provides some
errata fixes when changing cmode.
(BTW Russell I have already updated your patch
net: dsa: mv88e6xxx: populate supported_interfaces
from your net-queue branch.
I am rebasing your work on top of net-next and also adding some other
stuff. I will send you the patches later.)
Marek
next prev parent reply other threads:[~2021-11-04 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 17:17 [PATCH net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10 Marek Behún
2021-11-04 18:15 ` Russell King (Oracle)
2021-11-04 18:58 ` Marek Behún [this message]
2021-11-09 22:06 ` Andrew Lunn
2021-11-10 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104195828.199c58b9@thinkpad \
--to=kabel@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).