* [PATCH] amt: add IPV6 Kconfig dependency
@ 2021-11-08 11:12 Arnd Bergmann
2021-11-08 12:39 ` Taehee Yoo
2021-11-09 14:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-11-08 11:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Taehee Yoo
Cc: Arnd Bergmann, Loic Poulain, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This driver cannot be built-in if IPV6 is a loadable module:
x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
Add the idiomatic Kconfig dependency that all such modules
have.
Fixes: b9022b53adad ("amt: add control plane of amt interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 034dbd487c33..10506a4b66ef 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -294,6 +294,7 @@ config GTP
config AMT
tristate "Automatic Multicast Tunneling (AMT)"
depends on INET && IP_MULTICAST
+ depends on IPV6 || !IPV6
select NET_UDP_TUNNEL
help
This allows one to create AMT(Automatic Multicast Tunneling)
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] amt: add IPV6 Kconfig dependency
2021-11-08 11:12 [PATCH] amt: add IPV6 Kconfig dependency Arnd Bergmann
@ 2021-11-08 12:39 ` Taehee Yoo
2021-11-09 14:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Taehee Yoo @ 2021-11-08 12:39 UTC (permalink / raw)
To: Arnd Bergmann, David S. Miller, Jakub Kicinski
Cc: Arnd Bergmann, Loic Poulain, netdev, linux-kernel
Hi Arnd,
On 11/8/21 8:12 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver cannot be built-in if IPV6 is a loadable module:
>
> x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
> amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
>
> Add the idiomatic Kconfig dependency that all such modules
> have.
>
> Fixes: b9022b53adad ("amt: add control plane of amt interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 034dbd487c33..10506a4b66ef 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -294,6 +294,7 @@ config GTP
> config AMT
> tristate "Automatic Multicast Tunneling (AMT)"
> depends on INET && IP_MULTICAST
> + depends on IPV6 || !IPV6
> select NET_UDP_TUNNEL
> help
> This allows one to create AMT(Automatic Multicast Tunneling)
>
Acked-by: Taehee Yoo <ap420073@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] amt: add IPV6 Kconfig dependency
2021-11-08 11:12 [PATCH] amt: add IPV6 Kconfig dependency Arnd Bergmann
2021-11-08 12:39 ` Taehee Yoo
@ 2021-11-09 14:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-09 14:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: davem, kuba, ap420073, arnd, loic.poulain, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 8 Nov 2021 12:12:24 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver cannot be built-in if IPV6 is a loadable module:
>
> x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
> amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
>
> [...]
Here is the summary with links:
- amt: add IPV6 Kconfig dependency
https://git.kernel.org/netdev/net/c/9758aba8542b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-09 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-08 11:12 [PATCH] amt: add IPV6 Kconfig dependency Arnd Bergmann
2021-11-08 12:39 ` Taehee Yoo
2021-11-09 14:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).