From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7448C433FE for ; Wed, 10 Nov 2021 07:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC73A611C9 for ; Wed, 10 Nov 2021 07:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbhKJHfa (ORCPT ); Wed, 10 Nov 2021 02:35:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhKJHf3 (ORCPT ); Wed, 10 Nov 2021 02:35:29 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 460A7C061766 for ; Tue, 9 Nov 2021 23:32:42 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id m14so7035286edd.0 for ; Tue, 09 Nov 2021 23:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubique-spb-ru.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cTGGejto87Yfd+Or/2wKl4kYNhFQUtAwvWH4+KBmqxE=; b=QvFgqt3SoZ0dEcn17ueum3F0xdQXmTB4iSfy+gpVZTOt18jCs1QTzsKWfHkQFlYhHd mFHpYaI4wPLhFJ2/vFOR1LxSE87/IIqzzQSMOjY2gC44qr/EcR3/4hnKxuWLen1mNoeH L85QyeB/5eeKxD3YnFd1gg9euJolxHWNVOz+QCUQvdjIz3/InTuslqUp9Gz4CRRy2ceP L+djcDD6iJg8e4zKmZhfnCWmtVfijGEsZVbZghssZSeKsMgFaJrEDd8oVc8epx4gm8uE Pb299secRd8L4HHu+7qj9957liXGfgQno0w+Wpk8oTlOXu1YLgCIkQQKLP0POv/gjWDo DDEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cTGGejto87Yfd+Or/2wKl4kYNhFQUtAwvWH4+KBmqxE=; b=JxGx8KaRyEFQsdCUkVd2Xk4abN9BrwQrydYkmK9Lx2I1EomELJOZiU56XxMpN4q/UR w/m1aAf+L8NKPOmN39t86sR7Z2bJz/tIfx9/dLmx3BTok2G7WyVZeza2e6XFjXjchjEx dJna4uxHMpgYVc9PsP49L5/h7z96zal8xZ7KCHXYqmI+nxWkuiZW3Ka/VC/sxES9V3XL R4lN+CT2V+BEuGdEX5o08KcJW31p534RZIPg9/5sFdKQIXi9YJv1Jozrhuwr6W34ywil 7HWPx/E7A9vy19wJCoFcS/knyWWP4Tm5y8vQnM9bQfOEz3t8rtgHH3vADHgEQJloJ04V dEnA== X-Gm-Message-State: AOAM533zAkOBmmMIrt4uQudpoy6gBYqW69skAStS/7Y4sficfo9hdhul CdsaR7fbOSDx9/++EbaCs5oe4w== X-Google-Smtp-Source: ABdhPJwH2aZjv32N451FhTF+POV6sP3TK89HDiOvhg5szh+G/+tDUQIBgTt3nZElVD3ziLBhj0rgtg== X-Received: by 2002:a17:906:52d8:: with SMTP id w24mr18402197ejn.296.1636529560062; Tue, 09 Nov 2021 23:32:40 -0800 (PST) Received: from localhost ([154.21.15.43]) by smtp.gmail.com with ESMTPSA id w25sm4127656edv.57.2021.11.09.23.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 23:32:39 -0800 (PST) Date: Wed, 10 Nov 2021 11:32:35 +0400 From: Dmitrii Banshchikov To: Andrii Nakryiko Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , Networking , Andrey Ignatov , john.stultz@linaro.org, sboyd@kernel.org, Peter Ziljstra , Mark Rutland , rosted@goodmis.org Subject: Re: [PATCH bpf 2/2] selftests/bpf: Add tests for allowed helpers Message-ID: <20211110073235.4cwxqxeit3hgdluf@amnesia> References: <20211108164620.407305-1-me@ubique.spb.ru> <20211108164620.407305-3-me@ubique.spb.ru> <20211109064837.qtokqcxf6yj6zbig@amnesia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 09, 2021 at 05:16:14PM -0800, Andrii Nakryiko wrote: > On Mon, Nov 8, 2021 at 10:48 PM Dmitrii Banshchikov wrote: > > > > On Mon, Nov 08, 2021 at 08:46:20PM +0400, Dmitrii Banshchikov wrote: > > > This patch adds tests that bpf_ktime_get_coarse_ns() and bpf_timer_* and > > > bpf_spin_lock()/bpf_spin_unlock() helpers are forbidden in tracing > > > progs as it may result in various locking issues. > > > > > > Signed-off-by: Dmitrii Banshchikov > > > --- > > > tools/testing/selftests/bpf/test_verifier.c | 36 +++- > > > .../selftests/bpf/verifier/helper_allowed.c | 196 ++++++++++++++++++ > > > 2 files changed, 231 insertions(+), 1 deletion(-) > > > create mode 100644 tools/testing/selftests/bpf/verifier/helper_allowed.c > > > > > > diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c > > > index 25afe423b3f0..e16eab6fc3a9 100644 > > > --- a/tools/testing/selftests/bpf/test_verifier.c > > > +++ b/tools/testing/selftests/bpf/test_verifier.c > > > @@ -92,6 +92,7 @@ struct bpf_test { > > > int fixup_map_event_output[MAX_FIXUPS]; > > > int fixup_map_reuseport_array[MAX_FIXUPS]; > > > int fixup_map_ringbuf[MAX_FIXUPS]; > > > + int fixup_map_timer[MAX_FIXUPS]; > > > /* Expected verifier log output for result REJECT or VERBOSE_ACCEPT. > > > * Can be a tab-separated sequence of expected strings. An empty string > > > * means no log verification. > > > @@ -605,7 +606,7 @@ static int create_cgroup_storage(bool percpu) > > > * struct bpf_spin_lock l; > > > * }; > > > */ > > > -static const char btf_str_sec[] = "\0bpf_spin_lock\0val\0cnt\0l"; > > > +static const char btf_str_sec[] = "\0bpf_spin_lock\0val\0cnt\0l\0bpf_timer\0"; > > > > There is extra null byte at the end. > > Won't hurt, probably. But I wonder if it will be much easier to add > all those programs as C code and test from test_progs? Instead of all > this assembly. > > You can put all of them into a single file and have loop that disabled > all but one program at a time (using bpf_program__set_autoload()) and > loading it and validating that the load failed. WDYT? Will give it a try, thanks. -- Dmitrii Banshchikov