* [PATCH net-next] gve: fix unmatched u64_stats_update_end()
@ 2021-11-10 8:11 Dan Carpenter
2021-11-10 14:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-11-10 8:11 UTC (permalink / raw)
To: Jeroen de Borst, David Awogbemila
Cc: Catherine Sullivan, David S. Miller, Jakub Kicinski,
Bailey Forrest, Willem de Bruijn, Jordan Kim, Yangchun Fu, netdev,
kernel-janitors
The u64_stats_update_end() call is supposed to be inside the curly
braces so it pairs with the u64_stats_update_begin().
Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Based on the indenting. Not tested.
drivers/net/ethernet/google/gve/gve_rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index c8500babbd1d..3d04b5aff331 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -500,7 +500,8 @@ static struct sk_buff *gve_rx_skb(struct gve_priv *priv, struct gve_rx_ring *rx,
rx->rx_copied_pkt++;
rx->rx_frag_copy_cnt++;
rx->rx_copybreak_pkt++;
- } u64_stats_update_end(&rx->statss);
+ u64_stats_update_end(&rx->statss);
+ }
} else {
if (rx->data.raw_addressing) {
int recycle = gve_rx_can_recycle_buffer(page_info);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] gve: fix unmatched u64_stats_update_end()
2021-11-10 8:11 [PATCH net-next] gve: fix unmatched u64_stats_update_end() Dan Carpenter
@ 2021-11-10 14:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-10 14:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: jeroendb, awogbemila, csully, davem, kuba, bcf, willemb, jrkim,
yangchun, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 10 Nov 2021 11:11:09 +0300 you wrote:
> The u64_stats_update_end() call is supposed to be inside the curly
> braces so it pairs with the u64_stats_update_begin().
>
> Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Based on the indenting. Not tested.
>
> [...]
Here is the summary with links:
- [net-next] gve: fix unmatched u64_stats_update_end()
https://git.kernel.org/netdev/net/c/721111b1b29c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-10 8:11 [PATCH net-next] gve: fix unmatched u64_stats_update_end() Dan Carpenter
2021-11-10 14:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).