From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B907AC433F5 for ; Fri, 12 Nov 2021 22:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 917B861073 for ; Fri, 12 Nov 2021 22:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233088AbhKLWIU (ORCPT ); Fri, 12 Nov 2021 17:08:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231320AbhKLWIT (ORCPT ); Fri, 12 Nov 2021 17:08:19 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C545FC061766 for ; Fri, 12 Nov 2021 14:05:28 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id r132so6998076pgr.9 for ; Fri, 12 Nov 2021 14:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9uXsV0Y7/ouKh8DE96udNFYUZH1O8QGKdmM3wivH7yE=; b=NmrI848FlHK8ykeU/eFhvy4SnWkaLfDcatW234qleUJ+6uHz43F3SAAY0OhVKwFI0p 83f+Q50rXxQ1iGMZRdEnMSQUcBgJruRvxJxPUkGf5mjr4ON0ElN6sDhudgjfzgdnrxYR ke7UgLZpYimsYlNnHm7CshPV02Z3myWkAXfXgrmz693IuDkofJ8sn8h1h3sfC1khBLPm drGF9iWORaq08I2Vk5F+MuNR0yqv1nFZnCWY81bjTqvNnNXnm6MUTpbR3n8/V4+XsP0S odS9px+X57297sIoRPDjRKbKmxwvKi9rtlc2RYs4NSdkva125vmhk9EjIFy71hXn0xg5 1jZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9uXsV0Y7/ouKh8DE96udNFYUZH1O8QGKdmM3wivH7yE=; b=QG+QfjyzMxpJkpHNZBC7QiIDisy55WzgMZhpsJQVP2nnYHjMNkxp9rq7IHGStDM0k9 Gs9knk4VoocKksyafKQp7AgWMDQvI2GVyQ6GMVssnlgeH164XZz34Y0U+8bzjbwYZOoC MVZukx1BTDTf+GSULjuYAgciVXEcNWOguTvy4SSA7OrJ3luzjnq+MEtoGh8rx95+5BxQ nK3nOXVC7y7Jo3fdeOlhqrFnB56XMZADkSbVeiv9+CAxCrxgpmX5Lyil1cmhBaTOOfHw TwiSXvKBmLUsiT96V6kGTzweLucP8Giz0wKDmti0LP886yOapW0G6Aw/gj8hqBNzVWoF RZgQ== X-Gm-Message-State: AOAM533RAABBLnYh8ownUTng1r5uV7XzD+2D6ctDcneRAbxDcjMUwtzv GhJl4mScCyEi8fYsDbs7oI3YNMfS4GP8KgAA X-Google-Smtp-Source: ABdhPJxK04S8K2uqYWZRYq0qdlRC8CknexufW/8ci5fywSi9cBB3FXBVdzZd6GER81lwnv33h3+iQg== X-Received: by 2002:a63:4618:: with SMTP id t24mr11992696pga.430.1636754728264; Fri, 12 Nov 2021 14:05:28 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id f130sm7460976pfa.81.2021.11.12.14.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 14:05:28 -0800 (PST) Date: Fri, 12 Nov 2021 14:05:25 -0800 From: Stephen Hemminger To: Harshit Mogalapalli Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Jakub Kicinski , Yang Yingliang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: sched: sch_netem: Refactor code in 4-state loss generator Message-ID: <20211112140525.056a215b@hermes.local> In-Reply-To: <20211112213647.18062-1-harshit.m.mogalapalli@oracle.com> References: <20211112213647.18062-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 12 Nov 2021 13:36:47 -0800 Harshit Mogalapalli wrote: > Fixed comments to match description with variable names and > refactored code to match the convention as per [1]. > > To match the convention mapping is done as follows: > State 3 - LOST_IN_BURST_PERIOD > State 4 - LOST_IN_GAP_PERIOD > > [1] S. Salsano, F. Ludovici, A. Ordine, "Definition of a general > and intuitive loss model for packet networks and its implementation > in the Netem module in the Linux kernel" > > Fixes: a6e2fe17eba4 ("sch_netem: replace magic numbers with enumerate") > Signed-off-by: Harshit Mogalapalli Acked-by: Stephen Hemminger