From: Pavel Skripkin <paskripkin@gmail.com>
To: aelior@marvell.com, skalluru@marvell.com,
GR-everest-linux-l2@marvell.com, davem@davemloft.net,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Skripkin <paskripkin@gmail.com>
Subject: [PATCH] net: bnx2x: fix variable dereferenced before check
Date: Sun, 14 Nov 2021 01:36:36 +0300 [thread overview]
Message-ID: <20211113223636.11446-1-paskripkin@gmail.com> (raw)
Smatch says:
bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op()
warn: variable dereferenced before check 'ilt' (see line 638)
Move ilt_cli variable initialization _after_ ilt validation, because
it's unsafe to deref the pointer before validation check.
Fixes: 523224a3b3cd ("bnx2x, cnic, bnx2i: use new FW/HSI")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h
index 1835d2e451c0..fc7fce642666 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h
@@ -635,11 +635,13 @@ static int bnx2x_ilt_client_mem_op(struct bnx2x *bp, int cli_num,
{
int i, rc;
struct bnx2x_ilt *ilt = BP_ILT(bp);
- struct ilt_client_info *ilt_cli = &ilt->clients[cli_num];
+ struct ilt_client_info *ilt_cli;
if (!ilt || !ilt->lines)
return -1;
+ ilt_cli = &ilt->clients[cli_num];
+
if (ilt_cli->flags & (ILT_CLIENT_SKIP_INIT | ILT_CLIENT_SKIP_MEM))
return 0;
--
2.33.1
next reply other threads:[~2021-11-13 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 22:36 Pavel Skripkin [this message]
2021-11-13 22:41 ` [PATCH] net: bnx2x: fix variable dereferenced before check Pavel Skripkin
2021-11-15 14:12 ` Jakub Kicinski
2021-11-15 20:20 ` [PATCH] MAINTAINERS: remove GR-everest-linux-l2@marvell.com Pavel Skripkin
2021-11-16 8:10 ` Alok Prasad
2021-11-16 8:16 ` Alok Prasad
2021-11-16 14:13 ` [PATCH v2] " Pavel Skripkin
2021-11-17 3:10 ` patchwork-bot+netdevbpf
2021-11-15 13:30 ` [PATCH] net: bnx2x: fix variable dereferenced before check patchwork-bot+netdevbpf
2021-11-18 8:51 ` Johan Hovold
2021-11-18 9:00 ` Pavel Skripkin
2021-11-18 15:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113223636.11446-1-paskripkin@gmail.com \
--to=paskripkin@gmail.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).