From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] skbuff: Add helper function for head_frag and pfmemalloc
Date: Mon, 15 Nov 2021 13:27:43 +0100 [thread overview]
Message-ID: <20211115122743.2659-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <20211115085708.13901-1-yajun.deng@linux.dev>
From: Yajun Deng <yajun.deng@linux.dev>
Date: Mon, 15 Nov 2021 16:57:08 +0800
> This series of build_skb() has the same code, add skb_set_head_frag_pfmemalloc()
> for it, at the same time, in-line skb_propagate_pfmemalloc().
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> include/linux/skbuff.h | 19 ++++++++++++-------
> net/core/skbuff.c | 19 +++++--------------
> 2 files changed, 17 insertions(+), 21 deletions(-)
build_skb(), build_skb_around() and napi_build_skb() are 3-liners,
and all of their code is here in linux/skbuff.h. Would it make
sense to make them static inlines, and export their "__"
counterparts instead?
Thanks,
Al
prev parent reply other threads:[~2021-11-15 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 8:57 [PATCH net-next] skbuff: Add helper function for head_frag and pfmemalloc Yajun Deng
2021-11-15 12:27 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115122743.2659-1-alexandr.lobakin@intel.com \
--to=alexandr.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).