[PATCH net-next] net: ethernet: ti: cpsw: Enable PHY timestamping

[PATCH net-next] net: ethernet: ti: cpsw: Enable PHY timestamping

[Kurt Kanzenbach]

If the used PHYs also support hardware timestamping, all configuration requests
should be forwared to the PHYs instead of being processed by the MAC driver
itself.

This enables PHY timestamping in combination with the cpsw driver.

Tested with an am335x based board with two DP83640 PHYs connected to the cpsw
switch.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 drivers/net/ethernet/ti/cpsw_priv.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw_priv.c b/drivers/net/ethernet/ti/cpsw_priv.c
index ecc2a6b7e28f..c99dd9735087 100644
--- a/drivers/net/ethernet/ti/cpsw_priv.c
+++ b/drivers/net/ethernet/ti/cpsw_priv.c
@@ -710,20 +710,26 @@ int cpsw_ndo_ioctl(struct net_device *dev, struct ifreq *req, int cmd)
 	struct cpsw_priv *priv = netdev_priv(dev);
 	struct cpsw_common *cpsw = priv->cpsw;
 	int slave_no = cpsw_slave_index(cpsw, priv);
+	struct phy_device *phy;
 
 	if (!netif_running(dev))
 		return -EINVAL;
 
-	switch (cmd) {
-	case SIOCSHWTSTAMP:
-		return cpsw_hwtstamp_set(dev, req);
-	case SIOCGHWTSTAMP:
-		return cpsw_hwtstamp_get(dev, req);
+	phy = cpsw->slaves[slave_no].phy;
+
+	if (!phy_has_hwtstamp(phy)) {
+		switch (cmd) {
+		case SIOCSHWTSTAMP:
+			return cpsw_hwtstamp_set(dev, req);
+		case SIOCGHWTSTAMP:
+			return cpsw_hwtstamp_get(dev, req);
+		}
 	}
 
-	if (!cpsw->slaves[slave_no].phy)
-		return -EOPNOTSUPP;
-	return phy_mii_ioctl(cpsw->slaves[slave_no].phy, req, cmd);
+	if (phy)
+		return phy_mii_ioctl(phy, req, cmd);
+
+	return -EOPNOTSUPP;
 }
 
 int cpsw_ndo_set_tx_maxrate(struct net_device *ndev, int queue, u32 rate)
-- 
2.30.2

Re: [PATCH net-next] net: ethernet: ti: cpsw: Enable PHY timestamping

[Richard Cochran]

On Tue, Nov 16, 2021 at 09:03:25AM +0100, Kurt Kanzenbach wrote:
> If the used PHYs also support hardware timestamping, all configuration requests
> should be forwared to the PHYs instead of being processed by the MAC driver
> itself.
> 
> This enables PHY timestamping in combination with the cpsw driver.
> 
> Tested with an am335x based board with two DP83640 PHYs connected to the cpsw
> switch.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH net-next] net: ethernet: ti: cpsw: Enable PHY timestamping

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 16 Nov 2021 09:03:25 +0100 you wrote:
> If the used PHYs also support hardware timestamping, all configuration requests
> should be forwared to the PHYs instead of being processed by the MAC driver
> itself.
> 
> This enables PHY timestamping in combination with the cpsw driver.
> 
> Tested with an am335x based board with two DP83640 PHYs connected to the cpsw
> switch.
> 
> [...]

Here is the summary with links:
  - [net-next] net: ethernet: ti: cpsw: Enable PHY timestamping
    https://git.kernel.org/netdev/net-next/c/65483559dc0a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html