From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Jarod Wilson <jarod@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Denis Kirjanov <dkirjanov@suse.de>,
David Ahern <dsahern@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCH iproute2-next] bond: add missed_max option
Date: Tue, 16 Nov 2021 16:49:13 +0800 [thread overview]
Message-ID: <20211116084913.978450-1-liuhangbin@gmail.com> (raw)
In-Reply-To: <20211116084840.978383-1-liuhangbin@gmail.com>
Bond missed_max is the maximum number of arp_interval monitor cycle
for missed ARP replies. If this number is exceeded, link is reported as
down.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iplink_bond.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c
index 59c9e36d..069e7604 100644
--- a/ip/iplink_bond.c
+++ b/ip/iplink_bond.c
@@ -153,6 +153,7 @@ static void print_explain(FILE *f)
" [ ad_user_port_key PORTKEY ]\n"
" [ ad_actor_sys_prio SYSPRIO ]\n"
" [ ad_actor_system LLADDR ]\n"
+ " [ missed_max MISSED_MAX ]\n"
"\n"
"BONDMODE := balance-rr|active-backup|balance-xor|broadcast|802.3ad|balance-tlb|balance-alb\n"
"ARP_VALIDATE := none|active|backup|all|filter|filter_active|filter_backup\n"
@@ -180,7 +181,7 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
__u16 ad_user_port_key, ad_actor_sys_prio;
__u32 miimon, updelay, downdelay, peer_notify_delay, arp_interval, arp_validate;
__u32 arp_all_targets, resend_igmp, min_links, lp_interval;
- __u32 packets_per_slave;
+ __u32 packets_per_slave, missed_max;
unsigned int ifindex;
while (argc > 0) {
@@ -258,6 +259,12 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
invarg("invalid arp_all_targets", *argv);
arp_all_targets = get_index(arp_all_targets_tbl, *argv);
addattr32(n, 1024, IFLA_BOND_ARP_ALL_TARGETS, arp_all_targets);
+ } else if (strcmp(*argv, "missed_max") == 0) {
+ NEXT_ARG();
+ if (get_u32(&missed_max, *argv, 0))
+ invarg("invalid missed_max", *argv);
+
+ addattr32(n, 1024, IFLA_BOND_MISSED_MAX, missed_max);
} else if (matches(*argv, "primary") == 0) {
NEXT_ARG();
ifindex = ll_name_to_index(*argv);
@@ -453,6 +460,12 @@ static void bond_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
"arp_interval %u ",
rta_getattr_u32(tb[IFLA_BOND_ARP_INTERVAL]));
+ if (tb[IFLA_BOND_MISSED_MAX])
+ print_uint(PRINT_ANY,
+ "missed_max",
+ "missed_max %u ",
+ rta_getattr_u32(tb[IFLA_BOND_MISSED_MAX]));
+
if (tb[IFLA_BOND_ARP_IP_TARGET]) {
struct rtattr *iptb[BOND_MAX_ARP_TARGETS + 1];
int i;
--
2.31.1
next prev parent reply other threads:[~2021-11-16 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 8:48 [PATCH net-next] Bonding: add missed_max option Hangbin Liu
2021-11-16 8:49 ` Hangbin Liu [this message]
2021-11-16 20:00 ` Jakub Kicinski
2021-11-17 1:01 ` Hangbin Liu
2021-11-17 2:41 ` Jakub Kicinski
2021-11-17 7:20 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116084913.978450-1-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=dsahern@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).