From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: g@pengutronix.de, Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, kernel@pengutronix.de,
Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [RFC PATCH net-next] net: dsa: microchip: implement multi-bridge support
Date: Tue, 16 Nov 2021 14:16:57 +0100 [thread overview]
Message-ID: <20211116131657.GC16121@pengutronix.de> (raw)
In-Reply-To: <20211116124723.kivonrdbgqdxlryd@skbuf>
On Tue, Nov 16, 2021 at 02:47:23PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 16, 2021 at 09:39:03AM +0100, Oleksij Rempel wrote:
> > On Tue, Nov 16, 2021 at 01:45:46AM +0200, Vladimir Oltean wrote:
> >
> > .....
> > Probably I need to signal it some how from dsa driver, to let linux
> > bridge make proper decision and reduce logging noise.
>
> What logging noise?
I get this with current ksz driver:
[ 40.185928] br0: port 2(lan2) entered blocking state
[ 40.190924] br0: port 2(lan2) entered listening state
[ 41.043186] br0: port 2(lan2) entered blocking state
[ 55.512832] br0: port 1(lan1) entered learning state
[ 61.272802] br0: port 2(lan2) neighbor 8000.ae:1b:91:58:77:8b lost
[ 61.279192] br0: port 2(lan2) entered listening state
[ 63.113236] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 63.123314] br0: port 2(lan2) entered blocking state
[ 68.953098] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 70.872840] br0: port 1(lan1) entered forwarding state
[ 70.878183] br0: topology change detected, propagating
[ 70.883820] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 83.672804] br0: port 2(lan2) neighbor 8000.ae:1b:91:58:77:8b lost
[ 83.679181] br0: port 2(lan2) entered listening state
[ 85.113244] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 85.123313] br0: port 2(lan2) entered blocking state
[ 97.753160] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 103.513076] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 105.432801] br0: port 2(lan2) neighbor 8000.ae:1b:91:58:77:8b lost
[ 105.439221] br0: port 2(lan2) entered listening state
[ 107.113238] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 107.123326] br0: port 2(lan2) entered blocking state
[ 127.192807] br0: port 2(lan2) neighbor 8000.ae:1b:91:58:77:8b lost
[ 127.199220] br0: port 2(lan2) entered listening state
[ 129.113249] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 129.123378] br0: port 2(lan2) entered blocking state
[ 149.592804] br0: port 2(lan2) neighbor 8000.ae:1b:91:58:77:8b lost
[ 149.600308] br0: port 2(lan2) entered listening state
[ 151.113276] br0: received packet on lan1 with own address as source address (addr:00:0e:cd:00:cd:be, vlan:0)
[ 151.125213] br0: port 2(lan2) entered blocking state
Probably I have wrong expectation...
> > And since STP state is not directly configurable on this switch, it
> > probably means receive/transmit enable state of the port. So, packets
> > with matching MAC should be forwarded even if port is in the receive
> > disabled state. Correct?
>
> In the context we've been discussing so far, "forwarding" has a pretty
> specific meaning, which is autonomously redirecting from one front port
> to another. For link-local packets, what you want is "trapping", i.e.
> send to the CPU and to the CPU only.
Ok. Thank you!
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-11-16 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 11:10 [RFC PATCH net-next] net: dsa: microchip: implement multi-bridge support Oleksij Rempel
2021-11-10 12:36 ` Vladimir Oltean
2021-11-12 7:58 ` Oleksij Rempel
2021-11-15 23:45 ` Vladimir Oltean
2021-11-16 8:39 ` Oleksij Rempel
2021-11-16 12:47 ` Vladimir Oltean
2021-11-16 13:16 ` Oleksij Rempel [this message]
2021-11-16 13:40 ` Andrew Lunn
2021-11-16 13:53 ` Vladimir Oltean
2021-11-16 14:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116131657.GC16121@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=g@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).