From: Stephen Hemminger <stephen@networkplumber.org>
To: Maxim Petrov <mmrmaximuzz@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
gnault@redhat.com
Subject: Re: [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
Date: Wed, 17 Nov 2021 11:12:10 -0800 [thread overview]
Message-ID: <20211117111210.5b5741c9@hermes.local> (raw)
In-Reply-To: <091bdc88-9386-288e-25ba-7d369ad9a6b5@gmail.com>
On Wed, 17 Nov 2021 21:05:33 +0300
Maxim Petrov <mmrmaximuzz@gmail.com> wrote:
> Fix the wild bracket in the if clause leading to the error in the condition.
>
> Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
> ---
> tc/m_vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tc/m_vlan.c b/tc/m_vlan.c
> index 221083df..1b2b1d51 100644
> --- a/tc/m_vlan.c
> +++ b/tc/m_vlan.c
> @@ -279,8 +279,8 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg)
> ETH_ALEN, 0, b1, sizeof(b1));
> print_string(PRINT_ANY, "dst_mac", " dst_mac %s", b1);
> }
> - if (tb[TCA_VLAN_PUSH_ETH_SRC &&
> - RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN]) {
> + if (tb[TCA_VLAN_PUSH_ETH_SRC] &&
> + RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN) {
> ll_addr_n2a(RTA_DATA(tb[TCA_VLAN_PUSH_ETH_SRC]),
> ETH_ALEN, 0, b1, sizeof(b1));
> print_string(PRINT_ANY, "src_mac", " src_mac %s", b1);
Fixes: d61167dd88b4 ("m_vlan: add pop_eth and push_eth actions")
next prev parent reply other threads:[~2021-11-17 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 18:05 [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH Maxim Petrov
2021-11-17 19:12 ` Stephen Hemminger [this message]
2021-11-17 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117111210.5b5741c9@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=mmrmaximuzz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).