From: Florian Westphal <fw@strlen.de>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>,
Netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Re: "AVX2-based lookup implementation" has broken ebtables --among-src
Date: Wed, 17 Nov 2021 13:06:09 +0100 [thread overview]
Message-ID: <20211117120609.GI6326@breakpoint.cc> (raw)
In-Reply-To: <20211116173352.1a5ff66a@elisabeth>
Stefano Brivio <sbrivio@redhat.com> wrote:
> [Adding netfilter-devel]
>
> Hi Nikita,
>
> On Tue, 16 Nov 2021 11:51:01 +0300
> Nikita Yushchenko <nikita.yushchenko@virtuozzo.com> wrote:
>
> > Hello Stefano.
> >
> > I've found that nftables rule added by
> >
> > # ebtables -A INPUT --among-src 8:0:27:40:f7:9=192.168.56.10 -j log
> >
> > does not match packets on kernel 5.14 and on current mainline.
> > Although it matched correctly on kernel 4.18
> >
> > I've bisected this issue. It was introduced by your commit 7400b063969b ("nft_set_pipapo: Introduce
> > AVX2-based lookup implementation") from 5.7 development cycle.
> >
> > The nftables rule created by the above command uses concatenation:
> >
> > # nft list chain bridge filter INPUT
> > table bridge filter {
> > chain INPUT {
> > type filter hook input priority filter; policy accept;
> > ether saddr . ip saddr { 08:00:27:40:f7:09 . 192.168.56.10 } counter packets 0 bytes 0
> > log level notice flags ether
> > }
> > }
> >
> > Looks like the AVX2-based lookup does not process this correctly.
>
> Thanks for bisecting and reporting this! I'm looking into it now, I
> might be a bit slow as I'm currently traveling.
Might be a bug in ebtables. This is what nft monitor shows:
add chain bridge filter INPUT { type filter hook input priority filter;
policy accept; }
add rule bridge filter INPUT ether saddr . ip saddr {
08:00:27:40:f7:09 .
192.168.56.10-0x1297286e2b2 [..]
I can have a look at ebtables-nft side.
next prev parent reply other threads:[~2021-11-17 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 8:51 "AVX2-based lookup implementation" has broken ebtables --among-src Nikita Yushchenko
2021-11-16 16:33 ` Stefano Brivio
2021-11-17 12:06 ` Florian Westphal [this message]
2021-11-17 12:08 ` Nikita Yushchenko
2021-11-22 13:29 ` Stefano Brivio
2021-11-24 17:38 ` Stefano Brivio
2021-11-17 13:12 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117120609.GI6326@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikita.yushchenko@virtuozzo.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).