From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Mirko Lindner <mlindner@marvell.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] sky2: use PCI VPD API in eeprom ethtool ops
Date: Thu, 18 Nov 2021 12:38:13 -0800 [thread overview]
Message-ID: <20211118123813.2f11dcac@hermes.local> (raw)
In-Reply-To: <a12724c0-2aba-3d3c-358d-a26e0c73eb38@gmail.com>
On Thu, 18 Nov 2021 21:04:23 +0100
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> Recently pci_read/write_vpd_any() have been added to the PCI VPD API.
> These functions allow to access VPD address space outside the
> auto-detected VPD, and they can be used to significantly simplify the
> eeprom ethtool ops.
>
> Tested with a 88E8070 card with 1KB EEPROM.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
Looks like a good idea. I don't have sky2 hardware in a system anymore.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2021-11-18 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 20:04 [PATCH net-next] sky2: use PCI VPD API in eeprom ethtool ops Heiner Kallweit
2021-11-18 20:38 ` Stephen Hemminger [this message]
2021-11-19 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118123813.2f11dcac@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).