From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org
Subject: [PATCH net 06/11] netfilter: ctnetlink: fix filtering with CTA_TUPLE_REPLY
Date: Thu, 18 Nov 2021 23:26:13 +0100 [thread overview]
Message-ID: <20211118222618.433273-7-pablo@netfilter.org> (raw)
In-Reply-To: <20211118222618.433273-1-pablo@netfilter.org>
From: Florent Fourcot <florent.fourcot@wifirst.fr>
filter->orig_flags was used for a reply context.
Fixes: cb8aa9a3affb ("netfilter: ctnetlink: add kernel side filtering for dump")
Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nf_conntrack_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index f1e5443fe7c7..2663764d0b6e 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1011,7 +1011,7 @@ ctnetlink_alloc_filter(const struct nlattr * const cda[], u8 family)
CTA_TUPLE_REPLY,
filter->family,
&filter->zone,
- filter->orig_flags);
+ filter->reply_flags);
if (err < 0) {
err = -EINVAL;
goto err_filter;
--
2.30.2
next prev parent reply other threads:[~2021-11-18 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 22:26 [PATCH net 00/11] Netfilter fixes for net Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 01/11] selftests: netfilter: add a vrf+conntrack testcase Pablo Neira Ayuso
2021-11-19 11:10 ` patchwork-bot+netdevbpf
2021-11-18 22:26 ` [PATCH net 02/11] selftests: netfilter: extend nfqueue tests to cover vrf device Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 03/11] netfilter: nft_payload: Remove duplicated include in nft_payload.c Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 04/11] selftests: nft_nat: Improve port shadow test stability Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 05/11] selftests: nft_nat: Simplify port shadow notrack test Pablo Neira Ayuso
2021-11-18 22:26 ` Pablo Neira Ayuso [this message]
2021-11-18 22:26 ` [PATCH net 07/11] netfilter: ctnetlink: do not erase error code with EINVAL Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 08/11] netfilter: ipvs: Fix reuse connection if RS weight is 0 Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 09/11] netfilter: xt_IDLETIMER: replace snprintf in show functions with sysfs_emit Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 10/11] netfilter: flowtable: fix IPv6 tunnel addr match Pablo Neira Ayuso
2021-11-18 22:26 ` [PATCH net 11/11] selftests: nft_nat: switch port shadow test cases to socat Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118222618.433273-7-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).