From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A64CC433F5 for ; Fri, 19 Nov 2021 19:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D92361AA7 for ; Fri, 19 Nov 2021 19:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235851AbhKSTH7 (ORCPT ); Fri, 19 Nov 2021 14:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235809AbhKSTH6 (ORCPT ); Fri, 19 Nov 2021 14:07:58 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63AC9C061748 for ; Fri, 19 Nov 2021 11:04:56 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id h24so8634286pjq.2 for ; Fri, 19 Nov 2021 11:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7gKCFl0vWdtOCb/3aV8pldCMA2ZxKL7ucYb4JkITvAM=; b=e3GDIUh8jfYIpwnABL6s1/QtgS6Jm3imtY2w3vJ7zy3S2h6jeVjvTAxpTw5boylJNl TR1NSPBTGbkz3mOOFWNDbfQsOe5Wx4U6kFi5XRuf6NPVuDeolZ158Q8+ThGe1aSXO2oj /r+qfiG4u1Of4FrnjhZTMx9jW2l0CVunMYz2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7gKCFl0vWdtOCb/3aV8pldCMA2ZxKL7ucYb4JkITvAM=; b=A3u9CcFQSeQzb1oIV6q6heiaD4sCXdVcqwAQl51o+RGu5EGwznZTnBMDy5tvI4xP0s ZMs3lLs6oW/XBKNfk4XWmVitMOP3siODHFPXx6+YWqoIVe0y383CVFZCC2RtPbfRni40 ORx/n+i24Or6UuzMYZkosNRIMk2itOXHVYdY0dlL1VRXNFWqaOAJVoeyJADHtNuJe7/f 7oohYoUg9k7vbKoFx0MiNbnAe0O1YqDppFKrpC2S+n3OBTXqjlEw9Wr2NBQLP0/ZNtpx 3zCtzsdn0qFggIN90zigpl3wnXbyHPabFOcRSHPa4rJwa2Rga1dsh9n1nby4qrFNyYT2 Lvqg== X-Gm-Message-State: AOAM530XkMl1FPQC76axeSkP+i4Qf68eey5dGC30PWWp8XiskWfHpNr5 gsjsx6a6uBUSehomUJWVh3dWsw== X-Google-Smtp-Source: ABdhPJwDCxXYbbuuUuh3O/yYZjAZzQVmT1fRScATPyisj+4WtYIlCTcjvf6vxYHMu5Uorx79MCqaOw== X-Received: by 2002:a17:90b:1e06:: with SMTP id pg6mr2468744pjb.137.1637348695802; Fri, 19 Nov 2021 11:04:55 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c16sm323497pgl.82.2021.11.19.11.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 11:04:55 -0800 (PST) Date: Fri, 19 Nov 2021 11:04:54 -0800 From: Kees Cook To: Jakub Kicinski Cc: "Jason A. Donenfeld" , "Gustavo A . R . Silva" , "David S. Miller" , Jonathan Lemon , Alexander Lobakin , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Eric Dumazet , Cong Wang , Paolo Abeni , Talal Ahmad , Kevin Hao , Ilias Apalodimas , Kumar Kartikeya Dwivedi , Vasily Averin , linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] skbuff: Switch structure bounds to struct_group() Message-ID: <202111191103.074D77AF2@keescook> References: <20211118183615.1281978-1-keescook@chromium.org> <20211118231355.7a39d22f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202111191015.509A0BD@keescook> <20211119104144.7cb1eac6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20211119105253.1db523b5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211119105253.1db523b5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 19, 2021 at 10:53:05AM -0800, Jakub Kicinski wrote: > On Fri, 19 Nov 2021 10:41:44 -0800 Jakub Kicinski wrote: > > On Fri, 19 Nov 2021 10:26:19 -0800 Kees Cook wrote: > > > On Thu, Nov 18, 2021 at 11:13:55PM -0800, Jakub Kicinski wrote: > > > > This adds ~27k of these warnings to W=1 gcc builds: > > > > > > > > include/linux/skbuff.h:851:1: warning: directive in macro's argument list > > > > > > Hrm, I can't reproduce this, using several GCC versions and net-next. What > > > compiler version[1] and base commit[2] were used here? > > > > gcc version 11.2.1 20210728 (Red Hat 11.2.1-1) (GCC) > > > > HEAD was at: 3b1abcf12894 Merge tag 'regmap-no-bus-update-bits' of git://... > > Ah, damn, I just realized, it's probably sparse! The build sets C=1. *head desk* I looked right at the "C=1" (noting it was missing for the clang build) and didn't put it together. Let me see what I need to do to make sparse happy... -- Kees Cook