From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 1/7] 82596: use eth_hw_addr_set()
Date: Fri, 19 Nov 2021 06:21:49 -0800 [thread overview]
Message-ID: <20211119142155.3779933-2-kuba@kernel.org> (raw)
In-Reply-To: <20211119142155.3779933-1-kuba@kernel.org>
Byte by byte assignments.
Fixes build on m68k.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/i825xx/82596.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c
index b482f6f633bd..3ee89ae496d0 100644
--- a/drivers/net/ethernet/i825xx/82596.c
+++ b/drivers/net/ethernet/i825xx/82596.c
@@ -1178,7 +1178,8 @@ static struct net_device * __init i82596_probe(void)
DEB(DEB_PROBE,printk(KERN_INFO "%s: 82596 at %#3lx,", dev->name, dev->base_addr));
for (i = 0; i < 6; i++)
- DEB(DEB_PROBE,printk(" %2.2X", dev->dev_addr[i] = eth_addr[i]));
+ DEB(DEB_PROBE,printk(" %2.2X", eth_addr[i]));
+ eth_hw_addr_set(dev, eth_addr);
DEB(DEB_PROBE,printk(" IRQ %d.\n", dev->irq));
--
2.31.1
next prev parent reply other threads:[~2021-11-19 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:21 [PATCH net-next v2 0/7] net: constify netdev->dev_addr Jakub Kicinski
2021-11-19 14:21 ` Jakub Kicinski [this message]
2021-11-19 14:21 ` [PATCH net-next v2 2/7] bnx2x: constify static inline stub for dev_addr Jakub Kicinski
2021-11-19 14:21 ` [PATCH net-next v2 3/7] net: constify netdev->dev_addr Jakub Kicinski
2021-11-19 14:21 ` [PATCH net-next v2 4/7] net: unexport dev_addr_init() & dev_addr_flush() Jakub Kicinski
2021-11-19 14:21 ` [PATCH net-next v2 5/7] dev_addr: add a modification check Jakub Kicinski
2021-11-19 14:21 ` [PATCH net-next v2 6/7] dev_addr_list: put the first addr on the tree Jakub Kicinski
2021-11-19 14:21 ` [PATCH net-next v2 7/7] net: kunit: add a test for dev_addr_lists Jakub Kicinski
2021-11-19 15:46 ` [PATCH net-next v2 0/7] net: constify netdev->dev_addr David Miller
2021-11-20 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119142155.3779933-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).