From: John Fastabend <john.fastabend@gmail.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net, andrii@kernel.org
Cc: john.fastabend@gmail.com, bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH bpf 0/2] sockmap fix for test_map failure
Date: Fri, 19 Nov 2021 10:14:16 -0800 [thread overview]
Message-ID: <20211119181418.353932-1-john.fastabend@gmail.com> (raw)
CI test_map runs started failing because of a regression in the
sockmap tests. The case, caught by test_maps is that progs attached
to sockets are not detatched currently when sockets are removed
from a map. We resolve this in two patches. The first patch
fixes a subtle issue found from code review and the second
patch addresses the reported CI issue. This was recently introduced
by a race fix, see patches for details.
Sorry for the hassle here, seems we missed ./test_maps run before
pushing the offending patch or maybe we just got lucky on the
run we did locally. Either way should be resolved now.
Thanks,
John
John Fastabend (2):
bpf, sockmap: Attach map progs to psock early for feature probes
bpf, sockmap: Re-evaluate proto ops when psock is removed from sockmap
net/core/skmsg.c | 5 +++++
net/core/sock_map.c | 15 ++++++++++-----
2 files changed, 15 insertions(+), 5 deletions(-)
--
2.33.0
next reply other threads:[~2021-11-19 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 18:14 John Fastabend [this message]
2021-11-19 18:14 ` [PATCH bpf 1/2] bpf, sockmap: Attach map progs to psock early for feature probes John Fastabend
2021-11-19 18:14 ` [PATCH bpf 2/2] bpf, sockmap: Re-evaluate proto ops when psock is removed from sockmap John Fastabend
2021-11-20 0:00 ` [PATCH bpf 0/2] sockmap fix for test_map failure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119181418.353932-1-john.fastabend@gmail.com \
--to=john.fastabend@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).