From: Alessandro B Maurici <abmaurici@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] phy: fix possible double lock calling link changed handler
Date: Tue, 23 Nov 2021 13:06:34 -0300 [thread overview]
Message-ID: <20211123130634.14fa4972@work> (raw)
In-Reply-To: <YZz2irnGkrVQPjTb@lunn.ch>
On Tue, 23 Nov 2021 15:11:22 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> Yes, that is the change i would make. When adding the extra locks i
> missed that a driver was doing something like this. I will check all
> other callers to see if they are using it in odd contexts.
>
> Andrew
Andrew, this kinda of implementation is really hard to get in a fast review,
fortunately I happen to be testing one lan743x board with a 5.10.79 kernel
that had the new locks in place, and noticed that really fast, but I wrongly
assumed that call was okayish since the driver was on stable.
If you need to do some testing I will still have the hardware with me for
some time.
Alessandro
next prev parent reply other threads:[~2021-11-23 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 2:55 [PATCH] phy: fix possible double lock calling link changed handler Alessandro B Maurici
2021-11-23 4:18 ` Andrew Lunn
2021-11-23 4:49 ` Alessandro B Maurici
2021-11-23 8:21 ` Heiner Kallweit
2021-11-23 14:11 ` Andrew Lunn
2021-11-23 16:06 ` Alessandro B Maurici [this message]
2021-11-23 20:32 ` Heiner Kallweit
2021-11-23 22:31 ` Alessandro B Maurici
2021-11-23 14:09 ` Andrew Lunn
2021-11-23 14:14 ` Russell King (Oracle)
2021-11-23 15:58 ` Alessandro B Maurici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123130634.14fa4972@work \
--to=abmaurici@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).