From: Jiri Olsa <jolsa@redhat.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Martin KaFai Lau <kafai@fb.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: [PATCH 5/8] libbpf: Add support to attach multiple [ku]probes
Date: Wed, 24 Nov 2021 09:41:16 +0100 [thread overview]
Message-ID: <20211124084119.260239-6-jolsa@kernel.org> (raw)
In-Reply-To: <20211124084119.260239-1-jolsa@kernel.org>
Adding support to attach multiple [ku]probes.
Extending both bpf_kprobe_opts and bpf_uprobe_opts structs
with config values to define multiple probes within single
bpf_program__attach_[ku]probe_opts call.
For mutiple probes in bpf_program__attach_kprobe_opts function
the 'func_name' argument is ignored and probes are defined in
bpf_kprobe_opts struct with:
struct {
/* probes count */
__u32 cnt;
/* function names array */
char **funcs;
/* address/offset values array */
union {
__u64 *addrs;
__u64 *offs;
};
} multi;
For mutiple probes in bpf_program__attach_uprobe_opts function
both 'binary_path' and 'func_offset' arguments are ignored and
probes are defined in bpf_kprobe_opts struct with:
/* multi uprobe values */
struct {
/* probes count */
__u32 cnt;
/* paths names array */
const char **paths;
/* offsets values array */
__u64 *offs;
} multi;
The multiple probes attachment is enabled when multi.cnt != 0.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/include/uapi/linux/perf_event.h | 1 +
tools/lib/bpf/libbpf.c | 30 +++++++++++++++++++++++++--
tools/lib/bpf/libbpf.h | 25 ++++++++++++++++++++--
3 files changed, 52 insertions(+), 4 deletions(-)
diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
index bd8860eeb291..eea80709d1ed 100644
--- a/tools/include/uapi/linux/perf_event.h
+++ b/tools/include/uapi/linux/perf_event.h
@@ -414,6 +414,7 @@ struct perf_event_attr {
union {
__u32 wakeup_events; /* wakeup every n events */
__u32 wakeup_watermark; /* bytes before wakeup */
+ __u32 probe_cnt; /* number of [k,u] probes */
};
__u32 bp_type;
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 34219a0c39a7..b570e93de735 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -9631,6 +9631,11 @@ struct perf_event_open_args {
uint64_t offset;
int pid;
size_t ref_ctr_off;
+ struct {
+ __u32 probe_cnt;
+ __u64 config1;
+ __u64 config2;
+ } multi;
};
static int perf_event_open_probe(bool uprobe, struct perf_event_open_args *args)
@@ -9667,8 +9672,15 @@ static int perf_event_open_probe(bool uprobe, struct perf_event_open_args *args)
attr.size = sizeof(attr);
attr.type = type;
attr.config |= (__u64)ref_ctr_off << PERF_UPROBE_REF_CTR_OFFSET_SHIFT;
- attr.config1 = ptr_to_u64(args->name); /* kprobe_func or uprobe_path */
- attr.config2 = args->offset; /* kprobe_addr or probe_offset */
+
+ if (args->multi.probe_cnt) {
+ attr.probe_cnt = args->multi.probe_cnt;
+ attr.config1 = args->multi.config1;
+ attr.config2 = args->multi.config2;
+ } else {
+ attr.config1 = ptr_to_u64(args->name); /* kprobe_func or uprobe_path */
+ attr.config2 = args->offset; /* kprobe_addr or probe_offset */
+ }
/* pid filter is meaningful only for uprobes */
pfd = syscall(__NR_perf_event_open, &attr,
@@ -9807,7 +9819,14 @@ bpf_program__attach_kprobe_opts(const struct bpf_program *prog,
.pid = -1,
.ref_ctr_off = 0,
};
+ __u32 probe_cnt = OPTS_GET(opts, multi.cnt, false);
+ if (probe_cnt) {
+ args.multi.probe_cnt = probe_cnt;
+ args.multi.config1 = ptr_to_u64(OPTS_GET(opts, multi.funcs, false));
+ /* multi.addrs and multi.offs share the same array */
+ args.multi.config2 = ptr_to_u64(OPTS_GET(opts, multi.addrs, false));
+ }
pfd = perf_event_open_probe(false /* uprobe */, &args);
} else {
char probe_name[256];
@@ -10006,6 +10025,13 @@ bpf_program__attach_uprobe_opts(const struct bpf_program *prog, pid_t pid,
.pid = pid,
.ref_ctr_off = ref_ctr_off,
};
+ __u32 probe_cnt = OPTS_GET(opts, multi.cnt, false);
+
+ if (probe_cnt) {
+ args.multi.probe_cnt = probe_cnt;
+ args.multi.config1 = ptr_to_u64(OPTS_GET(opts, multi.paths, false));
+ args.multi.config2 = ptr_to_u64(OPTS_GET(opts, multi.offs, false));
+ }
pfd = perf_event_open_probe(true /* uprobe */, &args);
} else {
diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
index d02139fec4ac..ae072882b5dd 100644
--- a/tools/lib/bpf/libbpf.h
+++ b/tools/lib/bpf/libbpf.h
@@ -321,9 +321,21 @@ struct bpf_kprobe_opts {
size_t offset;
/* kprobe is return probe */
bool retprobe;
+ /* multi kprobe values */
+ struct {
+ /* probes count */
+ __u32 cnt;
+ /* function names array */
+ char **funcs;
+ /* address/offset values array */
+ union {
+ __u64 *addrs;
+ __u64 *offs;
+ };
+ } multi;
size_t :0;
};
-#define bpf_kprobe_opts__last_field retprobe
+#define bpf_kprobe_opts__last_field multi.addrs
LIBBPF_API struct bpf_link *
bpf_program__attach_kprobe(const struct bpf_program *prog, bool retprobe,
@@ -344,9 +356,18 @@ struct bpf_uprobe_opts {
__u64 bpf_cookie;
/* uprobe is return probe, invoked at function return time */
bool retprobe;
+ /* multi uprobe values */
+ struct {
+ /* probes count */
+ __u32 cnt;
+ /* paths names array */
+ const char **paths;
+ /* offsets values array */
+ __u64 *offs;
+ } multi;
size_t :0;
};
-#define bpf_uprobe_opts__last_field retprobe
+#define bpf_uprobe_opts__last_field multi.offs
LIBBPF_API struct bpf_link *
bpf_program__attach_uprobe(const struct bpf_program *prog, bool retprobe,
--
2.33.1
next prev parent reply other threads:[~2021-11-24 8:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:41 [RFC 0/8] perf/bpf: Add batch support for [ku]probes attach Jiri Olsa
2021-11-24 8:41 ` [PATCH 1/8] perf/kprobe: Add support to create multiple probes Jiri Olsa
2021-11-28 13:49 ` Masami Hiramatsu
2021-11-28 22:34 ` Jiri Olsa
2021-11-29 1:43 ` Masami Hiramatsu
2021-12-01 6:53 ` Andrii Nakryiko
2021-12-01 6:55 ` Andrii Nakryiko
2021-12-01 21:32 ` Jiri Olsa
2021-12-02 5:10 ` Alexei Starovoitov
2021-12-07 3:15 ` Andrii Nakryiko
2021-12-08 13:50 ` Jiri Olsa
2021-12-10 12:42 ` Jiri Olsa
2021-12-10 18:28 ` Andrii Nakryiko
2021-11-24 8:41 ` [PATCH 2/8] perf/uprobe: " Jiri Olsa
2021-11-24 8:41 ` [PATCH 3/8] libbpf: Add libbpf__kallsyms_parse function Jiri Olsa
2021-11-24 8:41 ` [PATCH 4/8] libbpf: Add struct perf_event_open_args Jiri Olsa
2021-11-24 8:41 ` Jiri Olsa [this message]
2021-11-24 8:41 ` [PATCH 6/8] libbpf: Add support for k[ret]probe.multi program section Jiri Olsa
2021-11-24 8:41 ` [PATCH 7/8] selftest/bpf: Add kprobe multi attach test Jiri Olsa
2021-11-24 8:41 ` [PATCH 8/8] selftest/bpf: Add uprobe " Jiri Olsa
2021-11-28 10:34 ` [RFC 0/8] perf/bpf: Add batch support for [ku]probes attach Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124084119.260239-6-jolsa@kernel.org \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).