From: Jiri Benc <jbenc@redhat.com>
To: "Fabian Frédérick" <fabf@skynet.be>
Cc: davem@davemloft.net, kuba@kernel.org, sbrivio@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: vxlan: Possible regression in vxlan_rcv()
Date: Wed, 24 Nov 2021 18:14:21 +0100 [thread overview]
Message-ID: <20211124181421.154b4470@redhat.com> (raw)
In-Reply-To: <1ad77777.15fd.17d4dc9bd96.Webtop.157@skynet.be>
On Tue, 23 Nov 2021 18:13:26 +0100 (CET), Fabian Frédérick wrote:
> Can someone tell me if the update is really ok or how I could check
> that code ?
> if VXLAN_F_REMCSUM_RX involves metadata checking I can ask to remove the
> patch.
I don't think it matters.
I doubt anyone is using remote checksum offloading (RCO). It was based
on a half thought-through idea. Local checksum offloading is superior,
it gives you the same performance for free, with full compatibility with
the base VXLAN standard. And even trying hard, I can't imagine anyone
could be using RCO with metadata dst.
I wouldn't object against removing RCO completely from VXLAN (and
moving the "generic" RCO pieces to net/ipv4/fou.c, which would become
its only user). It would simplify the code and I doubt anyone would
notice. I'm serious. Try googling for remcsumtx or remcsumrx and see
for yourself.
And, in case you still wonder, your patch seems fine to me. It's somehow
pointless, since it optimizes drops for an extension that nobody uses,
but it should not affect the code correctness. Probably. Whatever.
Jiri
prev parent reply other threads:[~2021-11-24 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 17:13 vxlan: Possible regression in vxlan_rcv() Fabian Frédérick
2021-11-24 17:14 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124181421.154b4470@redhat.com \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=fabf@skynet.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).