Re: [PATCH RFC net-next 03/12] net: dsa: replace phylink_get_interfaces() with phylink_get_caps()

Vladimir Oltean
2021-11-24T18:15:18Z

On Wed, Nov 24, 2021 at 05:52:38PM +0000, Russell King (Oracle) wrote:
> Phylink needs slightly more information than phylink_get_interfaces()
> allows us to get from the DSA drivers - we need the MAC capabilities.
> Replace the phylink_get_interfaces() method with phylink_get_caps() to
> allow DSA drivers to fill in the phylink_config MAC capabilities field
> as well.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---

The effects of submitting new API without any user :)

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> include/net/dsa.h | 4 ++--
> net/dsa/port.c | 5 ++---
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index eff5c44ba377..8ca9d50cbbc2 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -645,8 +645,8 @@ struct dsa_switch_ops {
> /*
> * PHYLINK integration
> */
> - void (*phylink_get_interfaces)(struct dsa_switch *ds, int port,
> - unsigned long *supported_interfaces);
> + void (*phylink_get_caps)(struct dsa_switch *ds, int port,
> + struct phylink_config *config);
> void (*phylink_validate)(struct dsa_switch *ds, int port,
> unsigned long *supported,
> struct phylink_link_state *state);
> diff --git a/net/dsa/port.c b/net/dsa/port.c
> index d928be884f01..6d5ebe61280b 100644
> --- a/net/dsa/port.c
> +++ b/net/dsa/port.c
> @@ -1094,9 +1094,8 @@ int dsa_port_phylink_create(struct dsa_port *dp)
> if (err)
> mode = PHY_INTERFACE_MODE_NA;
>
> - if (ds->ops->phylink_get_interfaces)
> - ds->ops->phylink_get_interfaces(ds, dp->index,
> - dp->pl_config.supported_interfaces);
> + if (ds->ops->phylink_get_caps)
> + ds->ops->phylink_get_caps(ds, dp->index, &dp->pl_config);
>
> dp->pl = phylink_create(&dp->pl_config, of_fwnode_handle(dp->dn),
> mode, &dsa_port_phylink_mac_ops);
> --
> 2.30.2
>