netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peilin Ye <yepeilin.cs@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	David Ahern <dsahern@gmail.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch net v3 2/2] selftests: add a test case for rp_filter
Date: Sun, 28 Nov 2021 22:40:56 -0800	[thread overview]
Message-ID: <20211129064056.GA2272@bytedance> (raw)
In-Reply-To: <YZ2YrPGJSEm8UAiv@Laptop-X1>

Hi all,

On Wed, Nov 24, 2021 at 09:43:08AM +0800, Hangbin Liu wrote:
> On Tue, Nov 23, 2021 at 05:05:14PM -0800, Cong Wang wrote:
> > My colleague Peilin is now looking into this.
> 
> Thanks Wang Cong and Peilin. Sorry I didn't get time to check on this
> issue.

I think I figured out the cause:

There was a bug [1] in ping's -I option, which has been fixed by iputils
commit f455fee41c07 ("ping: also bind the ICMP socket to the specific
device") [2] in 2016.

Before the fix, "ping -I" actually did _not_ bind the ICMP message
socket to device.  It only bound the "probe socket"; see "probe_fd" in
ping4_run().

Now, "ping -I" binds both sockets to device using SO_BINDTODEVICE, and
socket lookup is failing (when receiving ICMP_ECHOREPLY messages) for
our rp_filter test here, as David mentioned earlier.

I'm still thinking about how should we fix the test.  Any ideas?

[1] https://github.com/iputils/iputils/issues/55
[2] https://github.com/iputils/iputils/commit/f455fee41c077d4b700a473b2f5b3487b8febc1d

Thanks,
Peilin Ye


  reply	other threads:[~2021-11-29  6:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 21:41 [Patch net v3 0/2] ipv4: relax source validation check for loopback packets Cong Wang
2019-07-17 21:41 ` [Patch net v3 1/2] fib: " Cong Wang
2019-07-17 21:59   ` David Ahern
2019-07-17 21:41 ` [Patch net v3 2/2] selftests: add a test case for rp_filter Cong Wang
2019-07-17 21:54   ` David Ahern
2021-11-10  9:18   ` Hangbin Liu
2021-11-15  5:08     ` Cong Wang
2021-11-15 16:06       ` David Ahern
2021-11-17  3:19       ` Hangbin Liu
2021-11-17  4:15         ` David Ahern
2021-11-24  1:05           ` Cong Wang
2021-11-24  1:43             ` Hangbin Liu
2021-11-29  6:40               ` Peilin Ye [this message]
2019-07-17 22:23 ` [Patch net v3 0/2] ipv4: relax source validation check for loopback packets David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129064056.GA2272@bytedance \
    --to=yepeilin.cs@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).