netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <irusskikh@marvell.com>,
	<dbezrukov@marvell.com>, Sameer Saurabh <ssaurabh@marvell.com>
Subject: [PATCH net 3/7] atlantic: Fix to display FW bundle version instead of FW mac version.
Date: Mon, 29 Nov 2021 05:28:25 -0800	[thread overview]
Message-ID: <20211129132829.16038-4-skalluru@marvell.com> (raw)
In-Reply-To: <20211129132829.16038-1-skalluru@marvell.com>

From: Sameer Saurabh <ssaurabh@marvell.com>

The correct way to reflect firmware version is to use bundle version.
Hence populating the same instead of MAC fw version.

Fixes: c1be0bf092bd2 ("net: atlantic: common functions needed for basic A2 init/deinit hw_ops")
Signed-off-by: Sameer Saurabh <ssaurabh@marvell.com>
Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 .../ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c
index b7a9b0ed6df3..e164ac5b55a8 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c
@@ -500,9 +500,9 @@ u32 hw_atl2_utils_get_fw_version(struct aq_hw_s *self)
 	hw_atl2_shared_buffer_read_safe(self, version, &version);
 
 	/* A2 FW version is stored in reverse order */
-	return version.mac.major << 24 |
-	       version.mac.minor << 16 |
-	       version.mac.build;
+	return version.bundle.major << 24 |
+	       version.bundle.minor << 16 |
+	       version.bundle.build;
 }
 
 int hw_atl2_utils_get_action_resolve_table_caps(struct aq_hw_s *self,
-- 
2.27.0


  parent reply	other threads:[~2021-11-29 13:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 13:28 [PATCH net 0/7] net: atlantic: 11-2021 fixes Sudarsana Reddy Kalluru
2021-11-29 13:28 ` [PATCH net 1/7] atlantic: Increase delay for fw transactions Sudarsana Reddy Kalluru
2021-11-30  2:48   ` Andrew Lunn
2021-11-30  4:18     ` Sudarsana Reddy Kalluru
2021-11-29 13:28 ` [PATCH net 2/7] atlatnic: enable Nbase-t speeds with base-t Sudarsana Reddy Kalluru
2021-11-29 13:28 ` Sudarsana Reddy Kalluru [this message]
2021-11-29 13:28 ` [PATCH net 4/7] atlantic: Add missing DIDs and fix 115c Sudarsana Reddy Kalluru
2021-11-29 13:28 ` [PATCH net 5/7] Remove Half duplex mode speed capabilities Sudarsana Reddy Kalluru
2021-11-29 13:28 ` [PATCH net 6/7] atlantic: Fix statistics logic for production hardware Sudarsana Reddy Kalluru
2021-11-29 13:28 ` [PATCH net 7/7] atlantic: Remove warn trace message Sudarsana Reddy Kalluru
2021-11-29 14:30 ` [PATCH net 0/7] net: atlantic: 11-2021 fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129132829.16038-4-skalluru@marvell.com \
    --to=skalluru@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dbezrukov@marvell.com \
    --cc=irusskikh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssaurabh@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).