From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0013C4332F for ; Tue, 30 Nov 2021 09:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240240AbhK3Jf4 (ORCPT ); Tue, 30 Nov 2021 04:35:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:25442 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235582AbhK3Jfz (ORCPT ); Tue, 30 Nov 2021 04:35:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638264756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=95/wbwyuxE7DzbjpYWIIgT2MISDRD/0Z2RLccr1nMBk=; b=RwPrBlT8uXK8jPze6JfTHBKWSWLyoXrC/2mTsTQiA31SB2/EUk2QCUJXPhTpduq6BZcOrZ x2hkGGcEMA7n7kTOjQ0QTzxGYKkjzrjuNLKLjSPuzqCUFiUumokqcWNgS48/tbkTcT8OZP vwpODXhV0WhQJwuapShLFoDAW48SJRQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-ZyDCRssQNnudVw4FOnPy1g-1; Tue, 30 Nov 2021 04:32:34 -0500 X-MC-Unique: ZyDCRssQNnudVw4FOnPy1g-1 Received: by mail-ed1-f72.google.com with SMTP id a3-20020a05640213c300b003e7d12bb925so16464529edx.9 for ; Tue, 30 Nov 2021 01:32:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=95/wbwyuxE7DzbjpYWIIgT2MISDRD/0Z2RLccr1nMBk=; b=nQxSjLRbWej9Mnj7O0TUWm3Ko992cQmQmWKAdkS0Q3v5FcHq2lwuBHFXR4Q+botAlD /sfvtDnvleNWZhbXwPiglihK6+BvoFt0mP47LV7sK+HxB8GqPA/W1n+5Vw3GiizfJ8+8 0dtAPNLECI1t92lvCBU6unNvTZzE/5UNTSs73rrP8eBbD74D93fPmNldVXqB4k01ShVl gdXQ08fb2uQw0ykSFpuWIHhofKBIh8RL1jL9wyEM26vS0FQ6LbnwM+8MB4IL8/mdZOtt D0Cf1+wVg70MACNDilO5ofXZZvPp2hl55DdOjoWrq7RRKB78UhyvFJWCdRvNlJkGFXah 8LZQ== X-Gm-Message-State: AOAM532m00ZL5H89GvGGTDPPwoM+zOieDmGPB4NN9c6hlJ4e7F9SI89I XYb1EMeHt6QdoRE4Zna2aoCSNpnqLXRnt5OGwNTG4XALFeDIID9jVl2Aon/nLuYCxFs4/uDs/mL nwrkdqgRocUMpBPrA X-Received: by 2002:a05:6402:4413:: with SMTP id y19mr80697589eda.26.1638264753182; Tue, 30 Nov 2021 01:32:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDmTv7P796/A2e4IqQPa36J8ENyP8CCY9GhkFhEgsEHepB5C2PoVkKOSzCqO+t0lSL2tloFw== X-Received: by 2002:a05:6402:4413:: with SMTP id y19mr80697562eda.26.1638264752958; Tue, 30 Nov 2021 01:32:32 -0800 (PST) Received: from steredhat (host-79-46-195-175.retail.telecomitalia.it. [79.46.195.175]) by smtp.gmail.com with ESMTPSA id gz10sm8564363ejc.38.2021.11.30.01.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 01:32:32 -0800 (PST) Date: Tue, 30 Nov 2021 10:32:28 +0100 From: Stefano Garzarella To: Zhu Lingshan Cc: jasowang@redhat.com, mst@redhat.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ifcvf/vDPA: fix misuse virtio-net device config size for blk dev Message-ID: <20211130093228.iiz2r43e7mcgecnk@steredhat> References: <20211129093144.8033-1-lingshan.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211129093144.8033-1-lingshan.zhu@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 29, 2021 at 05:31:44PM +0800, Zhu Lingshan wrote: >This commit fixes a misuse of virtio-net device config size issue >for virtio-block devices. > >A new member config_size in struct ifcvf_hw is introduced and would >be initialized through vdpa_dev_add() to record correct device >config size. > >Signed-off-by: Zhu Lingshan >Reported-and-suggested-by: Stefano Garzarella >Fixes: 6ad31d162a4e ("vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA") >Cc: >--- > drivers/vdpa/ifcvf/ifcvf_base.c | 41 +++++++++++++++++++++++++-------- > drivers/vdpa/ifcvf/ifcvf_base.h | 9 +++++--- > drivers/vdpa/ifcvf/ifcvf_main.c | 24 ++++--------------- > 3 files changed, 41 insertions(+), 33 deletions(-) The patch LGTM. Maybe we could add in the description that we rename some fields and functions in a more generic way. In both cases: Reviewed-by: Stefano Garzarella Thanks, Stefano