From: kernel test robot <lkp@intel.com>
To: Dust Li <dust.li@linux.alibaba.com>,
Karsten Graul <kgraul@linux.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ursula Braun <ubraun@linux.ibm.com>
Cc: kbuild-all@lists.01.org, Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup_early
Date: Wed, 1 Dec 2021 02:07:46 +0800 [thread overview]
Message-ID: <202112010159.e2LA9rIR-lkp@intel.com> (raw)
In-Reply-To: <20211130151731.55951-1-dust.li@linux.alibaba.com>
Hi Dust,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Dust-Li/net-smc-fix-wrong-list_del-in-smc_lgr_cleanup_early/20211130-232151
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 34d8778a943761121f391b7921f79a7adbe1feaf
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211201/202112010159.e2LA9rIR-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9b9af6a458f20989d91478dc8e038325978e16d5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dust-Li/net-smc-fix-wrong-list_del-in-smc_lgr_cleanup_early/20211130-232151
git checkout 9b9af6a458f20989d91478dc8e038325978e16d5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash net/smc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/smc/smc_core.c: In function 'smc_lgr_cleanup_early':
>> net/smc/smc_core.c:628:27: warning: variable 'lgr_list' set but not used [-Wunused-but-set-variable]
628 | struct list_head *lgr_list;
| ^~~~~~~~
vim +/lgr_list +628 net/smc/smc_core.c
8f9dde4bf230f5 Guvenc Gulce 2020-12-01 624
51e3dfa8906ace Ursula Braun 2020-02-25 625 void smc_lgr_cleanup_early(struct smc_connection *conn)
51e3dfa8906ace Ursula Braun 2020-02-25 626 {
51e3dfa8906ace Ursula Braun 2020-02-25 627 struct smc_link_group *lgr = conn->lgr;
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 @628 struct list_head *lgr_list;
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 629 spinlock_t *lgr_lock;
51e3dfa8906ace Ursula Braun 2020-02-25 630
51e3dfa8906ace Ursula Braun 2020-02-25 631 if (!lgr)
51e3dfa8906ace Ursula Braun 2020-02-25 632 return;
51e3dfa8906ace Ursula Braun 2020-02-25 633
51e3dfa8906ace Ursula Braun 2020-02-25 634 smc_conn_free(conn);
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 635 lgr_list = smc_lgr_list_head(lgr, &lgr_lock);
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 636 spin_lock_bh(lgr_lock);
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 637 /* do not use this link group for new connections */
9b9af6a458f209 Dust Li 2021-11-30 638 if (!list_empty(&lgr->list))
9b9af6a458f209 Dust Li 2021-11-30 639 list_del_init(&lgr->list);
9ec6bf19ec8bb1 Karsten Graul 2020-05-03 640 spin_unlock_bh(lgr_lock);
f9aab6f2ce5761 Ursula Braun 2020-09-10 641 __smc_lgr_terminate(lgr, true);
51e3dfa8906ace Ursula Braun 2020-02-25 642 }
51e3dfa8906ace Ursula Braun 2020-02-25 643
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-11-30 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:17 [PATCH net] net/smc: fix wrong list_del in smc_lgr_cleanup_early Dust Li
2021-11-30 16:20 ` Karsten Graul
2021-11-30 18:07 ` kernel test robot [this message]
2021-12-01 2:22 ` dust.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112010159.e2LA9rIR-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=kbuild-all@lists.01.org \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).