From: Jiri Olsa <jolsa@redhat.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>
Subject: [PATCH bpf-next 0/3] bpf: Add helpers to access traced function arguments
Date: Sat, 4 Dec 2021 15:06:57 +0100 [thread overview]
Message-ID: <20211204140700.396138-1-jolsa@kernel.org> (raw)
hi,
adding new helpers to access traced function arguments that
came out of the trampoline batch changes [1].
Get n-th argument of the traced function:
long bpf_get_func_arg(void *ctx, u32 n, u64 *value)
Get return value of the traced function:
long bpf_get_func_ret(void *ctx, u64 *value)
Get arguments count of the traced funtion:
long bpf_get_func_arg_cnt(void *ctx)
changes from original post [1]:
- change helpers names to get_func_*
- change helpers to return error values instead of
direct values
- replaced stack_size usage with specific offset
variables in arch_prepare_bpf_trampoline
- add comment on stack layout
- add more tests
- allow bpf_get_func_ret in FENTRY programs
- use BPF_LSH instead of BPF_MUL
thanks,
jirka
[1] https://lore.kernel.org/bpf/20211118112455.475349-1-jolsa@kernel.org/
---
Jiri Olsa (3):
bpf, x64: Replace some stack_size usage with offset variables
bpf: Add get_func_[arg|ret|arg_cnt] helpers
selftests/bpf: Add tests for get_func_[arg|ret|arg_cnt] helpers
arch/x86/net/bpf_jit_comp.c | 55 +++++++++++++++++++++++++++++++++------------
include/uapi/linux/bpf.h | 28 +++++++++++++++++++++++
kernel/bpf/verifier.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
kernel/trace/bpf_trace.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++-
tools/include/uapi/linux/bpf.h | 28 +++++++++++++++++++++++
tools/testing/selftests/bpf/prog_tests/get_func_args_test.c | 38 +++++++++++++++++++++++++++++++
tools/testing/selftests/bpf/progs/get_func_args_test.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
7 files changed, 375 insertions(+), 17 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
create mode 100644 tools/testing/selftests/bpf/progs/get_func_args_test.c
next reply other threads:[~2021-12-04 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 14:06 Jiri Olsa [this message]
2021-12-04 14:06 ` [PATCH bpf-next 1/3] bpf, x64: Replace some stack_size usage with offset variables Jiri Olsa
2021-12-06 19:19 ` John Fastabend
2021-12-06 21:26 ` Andrii Nakryiko
2021-12-06 21:41 ` Andrii Nakryiko
2021-12-07 14:25 ` Jiri Olsa
2021-12-04 14:06 ` [PATCH bpf-next 2/3] bpf: Add get_func_[arg|ret|arg_cnt] helpers Jiri Olsa
2021-12-06 19:39 ` John Fastabend
2021-12-06 20:17 ` Jiri Olsa
2021-12-06 21:54 ` Andrii Nakryiko
2021-12-07 17:23 ` Jiri Olsa
2021-12-04 14:07 ` [PATCH bpf-next 3/3] selftests/bpf: Add tests for " Jiri Olsa
2021-12-06 22:03 ` Andrii Nakryiko
2021-12-07 18:14 ` Jiri Olsa
2021-12-07 22:54 ` Andrii Nakryiko
2021-12-08 16:38 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204140700.396138-1-jolsa@kernel.org \
--to=jolsa@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).