From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jackie Liu <liu.yun@linux.dev>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power
Date: Mon, 6 Dec 2021 19:50:07 +0100 [thread overview]
Message-ID: <20211206195007.4892af4f@thinkpad> (raw)
In-Reply-To: <Ya4T5x0EOktaF2FU@lunn.ch>
On Mon, 6 Dec 2021 14:45:11 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, Dec 06, 2021 at 06:13:52PM +0800, Jackie Liu wrote:
> > From: Jackie Liu <liuyun01@kylinos.cn>
> >
> > 'err' is not initialized. If the value of cmode is not in the switch case,
> > it will cause a logic error and return early.
>
> Same fix as: <20211206113219.17640-1-amhamza.mgc@gmail.com>
>
> At least here some analysis has been done why there is a warning.
>
> Should we add a default?
>
> Andrew
indeed it should be err=0
prev parent reply other threads:[~2021-12-06 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 10:13 [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power Jackie Liu
2021-12-06 13:45 ` Andrew Lunn
2021-12-06 18:50 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206195007.4892af4f@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=liu.yun@linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).