* [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power
@ 2021-12-06 10:13 Jackie Liu
2021-12-06 13:45 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Jackie Liu @ 2021-12-06 10:13 UTC (permalink / raw)
To: kabel; +Cc: davem, netdev, liu.yun
From: Jackie Liu <liuyun01@kylinos.cn>
'err' is not initialized. If the value of cmode is not in the switch case,
it will cause a logic error and return early.
Fixes: 7527d66260ac ("net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver")
Reported-by: kernel-bot <kernel-robot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/net/dsa/mv88e6xxx/serdes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 55273013bfb5..33727439724a 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -1507,7 +1507,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
bool on)
{
u8 cmode = chip->ports[port].cmode;
- int err;
+ int err = 0;
if (port != 0 && port != 9 && port != 10)
return -EOPNOTSUPP;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power
2021-12-06 10:13 [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power Jackie Liu
@ 2021-12-06 13:45 ` Andrew Lunn
2021-12-06 18:50 ` Marek Behún
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2021-12-06 13:45 UTC (permalink / raw)
To: Jackie Liu; +Cc: kabel, davem, netdev
On Mon, Dec 06, 2021 at 06:13:52PM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> 'err' is not initialized. If the value of cmode is not in the switch case,
> it will cause a logic error and return early.
Same fix as: <20211206113219.17640-1-amhamza.mgc@gmail.com>
At least here some analysis has been done why there is a warning.
Should we add a default?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power
2021-12-06 13:45 ` Andrew Lunn
@ 2021-12-06 18:50 ` Marek Behún
0 siblings, 0 replies; 3+ messages in thread
From: Marek Behún @ 2021-12-06 18:50 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Jackie Liu, davem, netdev
On Mon, 6 Dec 2021 14:45:11 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, Dec 06, 2021 at 06:13:52PM +0800, Jackie Liu wrote:
> > From: Jackie Liu <liuyun01@kylinos.cn>
> >
> > 'err' is not initialized. If the value of cmode is not in the switch case,
> > it will cause a logic error and return early.
>
> Same fix as: <20211206113219.17640-1-amhamza.mgc@gmail.com>
>
> At least here some analysis has been done why there is a warning.
>
> Should we add a default?
>
> Andrew
indeed it should be err=0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-06 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-06 10:13 [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes_power Jackie Liu
2021-12-06 13:45 ` Andrew Lunn
2021-12-06 18:50 ` Marek Behún
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).