[PATCH net-next 00/11] Replace DSA dp->priv with tagger-owned storage

Vladimir Oltean
2021-12-08T20:05:49Z

Ansuel's recent work on qca8k register access over Ethernet:
https://patchwork.kernel.org/project/netdevbpf/cover/20211207145942.7444-1-ansuelsmth@gmail.com/
has triggered me to do something which I should've done for a longer
time:
https://patchwork.kernel.org/project/netdevbpf/patch/20211109095013.27829-7-martin.kaistra@linutronix.de/#24585521
which is to replace dp->priv with something that has less caveats.

The dp->priv was introduced when sja1105 needed to hold stateful
information in the tagging protocol driver. In that design, dp->priv
held memory allocated by the switch driver, because the tagging protocol
driver design was 100% stateless.

Some years have passed and others have started to feel the need for
stateful information kept by the tagger, as well as passing data back
and forth between the tagging protocol driver and the switch driver.
This isn't possible cleanly in DSA due to a circular dependency which
leads to broken module autoloading:
https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/

This patchset introduces a framework that resembles something normal,
which allows data to be passed from the tagging protocol driver (things
like switch management packets, which aren't intended for the network
stack) to the switch driver, while the tagging protocol still remains
more or less stateless. The overall design of the framework was
discussed with Ansuel too and it appears to be flexible enough to cover
the "register access over Ethernet" use case. Additionally, the existing
uses of dp->priv, which have mainly to do with PTP timestamping, have
also been migrated.

Vladimir Oltean (11):
net: dsa: introduce tagger-owned storage for private and shared data
net: dsa: tag_ocelot: convert to tagger-owned data
net: dsa: sja1105: let deferred packets time out when sent to ports
going down
net: dsa: sja1105: bring in line deferred xmit implementation with
ocelot-8021q
net: dsa: sja1105: remove hwts_tx_en from tagger data
net: dsa: sja1105: make dp->priv point directly to sja1105_tagger_data
net: dsa: sja1105: move ts_id from sja1105_tagger_data
net: dsa: tag_sja1105: convert to tagger-owned data
Revert "net: dsa: move sja1110_process_meta_tstamp inside the tagging
protocol driver"
net: dsa: tag_sja1105: split sja1105_tagger_data into private and
public sections
net: dsa: remove dp->priv

drivers/net/dsa/ocelot/felix.c | 64 ++-----
drivers/net/dsa/sja1105/sja1105.h | 6 +-
drivers/net/dsa/sja1105/sja1105_main.c | 121 ++++---------
drivers/net/dsa/sja1105/sja1105_ptp.c | 86 ++++++----
drivers/net/dsa/sja1105/sja1105_ptp.h | 24 +++
include/linux/dsa/ocelot.h | 12 +-
include/linux/dsa/sja1105.h | 61 +++----
include/net/dsa.h | 18 +-
net/dsa/dsa2.c | 73 +++++++-
net/dsa/dsa_priv.h | 1 +
net/dsa/switch.c | 14 ++
net/dsa/tag_ocelot_8021q.c | 73 +++++++-
net/dsa/tag_sja1105.c | 224 +++++++++++++++++--------
13 files changed, 483 insertions(+), 294 deletions(-)

--
2.25.1