From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-can@vger.kernel.org,
Oliver Hartkopp <socketcan@hartkopp.net>,
Jimmy Assarsson <extja@kvaser.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH v5 3/5] can: do not copy the payload of RTR frames
Date: Fri, 10 Dec 2021 08:35:45 +0100 [thread overview]
Message-ID: <20211210073545.qdldwmaykts5dr4u@pengutronix.de> (raw)
In-Reply-To: <20211207121531.42941-4-mailhol.vincent@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On 07.12.2021 21:15:29, Vincent Mailhol wrote:
> The actual payload length of the CAN Remote Transmission Request (RTR)
> frames is always 0, i.e. nothing is transmitted on the wire. However,
^^^^^^^
I've changed this to "no payload" to make it more unambiguous.
> those RTR frames still use the DLC to indicate the length of the
> requested frame.
>
> For this reason, it is incorrect to copy the payload of RTR frames
> (the payload buffer would only contain garbage data). This patch
> encapsulates the payload copy in a check toward the RTR flag.
>
> CC: Yasushi SHOJI <yashi@spacecubics.com>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-10 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 12:15 [PATCH v5 0/5] fix statistics and payload issues for error Vincent Mailhol
2021-12-07 12:15 ` [PATCH v5 1/5] can: do not increase rx statistics when generating a CAN rx error message frame Vincent Mailhol
2021-12-07 12:15 ` [PATCH v5 2/5] can: kvaser_usb: do not increase tx statistics when sending error message frames Vincent Mailhol
2021-12-07 12:15 ` [PATCH v5 3/5] can: do not copy the payload of RTR frames Vincent Mailhol
2021-12-10 7:35 ` Marc Kleine-Budde [this message]
2021-12-10 8:02 ` Marc Kleine-Budde
2021-12-10 8:57 ` Yasushi SHOJI
2021-12-07 12:15 ` [PATCH v5 4/5] can: do not increase rx_bytes statistics for " Vincent Mailhol
2021-12-07 12:15 ` [PATCH v5 5/5] can: do not increase tx_bytes " Vincent Mailhol
2021-12-08 9:16 ` [PATCH v5 0/5] fix statistics and payload issues for error Marc Kleine-Budde
2021-12-09 23:21 ` Stefan Mätje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210073545.qdldwmaykts5dr4u@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=extja@kvaser.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=yashi@spacecubics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox