From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH V2 net-next 0/6] net: netns refcount tracking, base series
Date: Thu, 9 Dec 2021 23:44:20 -0800 [thread overview]
Message-ID: <20211210074426.279563-1-eric.dumazet@gmail.com> (raw)
From: Eric Dumazet <edumazet@google.com>
We have 100+ syzbot reports about netns being dismantled too soon,
still unresolved as of today.
We think a missing get_net() or an extra put_net() is the root cause.
In order to find the bug(s), and be able to spot future ones,
this patch adds CONFIG_NET_NS_REFCNT_TRACKER and new helpers
to precisely pair all put_net() with corresponding get_net().
To use these helpers, each data structure owning a refcount
should also use a "netns_tracker" to pair the get() and put().
Small sections of codes where the get()/put() are in sight
do not need to have a tracker, because they are short lived,
but in theory it is also possible to declare an on-stack tracker.
v2: Include core networking patches only.
Eric Dumazet (6):
net: add networking namespace refcount tracker
net: add netns refcount tracker to struct sock
net: add netns refcount tracker to struct seq_net_private
net: sched: add netns refcount tracker to struct tcf_exts
l2tp: add netns refcount tracker to l2tp_dfs_seq_data
ppp: add netns refcount tracker
drivers/net/ppp/ppp_generic.c | 5 +++--
fs/proc/proc_net.c | 19 ++++++++++++++++---
include/linux/netdevice.h | 9 +--------
include/linux/seq_file_net.h | 3 ++-
include/net/net_namespace.h | 34 ++++++++++++++++++++++++++++++++++
include/net/net_trackers.h | 18 ++++++++++++++++++
include/net/pkt_cls.h | 8 ++++++--
include/net/sock.h | 2 ++
net/Kconfig.debug | 9 +++++++++
net/core/net_namespace.c | 3 +++
net/core/sock.c | 6 +++---
net/l2tp/l2tp_debugfs.c | 9 +++++----
12 files changed, 102 insertions(+), 23 deletions(-)
create mode 100644 include/net/net_trackers.h
--
2.34.1.173.g76aa8bc2d0-goog
next reply other threads:[~2021-12-10 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 7:44 Eric Dumazet [this message]
2021-12-10 7:44 ` [PATCH V2 net-next 1/6] net: add networking namespace refcount tracker Eric Dumazet
2021-12-10 7:44 ` [PATCH V2 net-next 2/6] net: add netns refcount tracker to struct sock Eric Dumazet
2021-12-10 7:44 ` [PATCH V2 net-next 3/6] net: add netns refcount tracker to struct seq_net_private Eric Dumazet
2021-12-10 7:44 ` [PATCH V2 net-next 4/6] net: sched: add netns refcount tracker to struct tcf_exts Eric Dumazet
2021-12-10 7:44 ` [PATCH V2 net-next 5/6] l2tp: add netns refcount tracker to l2tp_dfs_seq_data Eric Dumazet
2021-12-10 7:44 ` [PATCH V2 net-next 6/6] ppp: add netns refcount tracker Eric Dumazet
2021-12-10 16:20 ` [PATCH V2 net-next 0/6] net: netns refcount tracking, base series patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210074426.279563-1-eric.dumazet@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox