Re: [PATCH bpf-next v3 7/9] net/netfilter: Add unstable CT lookup helpers for XDP and TC-BPF

Pablo Neira Ayuso
2021-12-10T23:03:41Z

On Fri, Dec 10, 2021 at 09:01:29PM +0530, Kumar Kartikeya Dwivedi wrote:
> On Fri, Dec 10, 2021 at 08:39:14PM IST, Pablo Neira Ayuso wrote:
> > On Fri, Dec 10, 2021 at 06:32:28PM +0530, Kumar Kartikeya Dwivedi wrote:
> > [...]
> > > net/netfilter/nf_conntrack_core.c | 252 ++++++++++++++++++++++++++++++
> > > 7 files changed, 497 insertions(+), 1 deletion(-)
> > >
> > [...]
> > > diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> > > index 770a63103c7a..85042cb6f82e 100644
> > > --- a/net/netfilter/nf_conntrack_core.c
> > > +++ b/net/netfilter/nf_conntrack_core.c
> >
> > Please, keep this new code away from net/netfilter/nf_conntrack_core.c
>
> Ok. Can it be a new file under net/netfilter, or should it live elsewhere?

IPVS and OVS use conntrack for already quite a bit of time and they
keep their code in their respective folders.

Thanks.