netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 0/2] net: ipa: fix SDX55 interconnects
@ 2021-12-10 16:37 Alex Elder
  2021-12-10 16:37 ` [PATCH net-next 1/2] ARM: dts: qcom: sdx55: fix IPA interconnect definitions Alex Elder
  2021-12-10 16:37 ` [PATCH net-next 2/2] net: ipa: fix IPA v4.5 interconnect data Alex Elder
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Elder @ 2021-12-10 16:37 UTC (permalink / raw)
  To: davem, kuba
  Cc: david, manivannan.sadhasivam, jponduru, avuyyuru, bjorn.andersson,
	cpratapa, subashab, evgreen, elder, netdev, linux-arm-msm,
	linux-kernel

The SDX55 SoC has IPA v4.5.  It currently represents the path
between IPA and main memory using two consecutive interconnects.
This was an optimization--not required for correct operation--and
complicates things unnecessarily.  It also does not conform to the
IPA binding (as pointed out by David Heidelberg).

This series fixes this by combining the two interconnects into one.

					-Alex

Alex Elder (2):
  ARM: dts: qcom: sdx55: fix IPA interconnect definitions
  net: ipa: fix IPA v4.5 interconnect data

 arch/arm/boot/dts/qcom-sdx55.dtsi | 6 ++----
 drivers/net/ipa/ipa_data-v4.5.c   | 7 +------
 2 files changed, 3 insertions(+), 10 deletions(-)

-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH net-next 1/2] ARM: dts: qcom: sdx55: fix IPA interconnect definitions
  2021-12-10 16:37 [PATCH net-next 0/2] net: ipa: fix SDX55 interconnects Alex Elder
@ 2021-12-10 16:37 ` Alex Elder
  2021-12-10 16:37 ` [PATCH net-next 2/2] net: ipa: fix IPA v4.5 interconnect data Alex Elder
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2021-12-10 16:37 UTC (permalink / raw)
  To: davem, kuba
  Cc: david, manivannan.sadhasivam, jponduru, avuyyuru, bjorn.andersson,
	cpratapa, subashab, evgreen, elder, netdev, linux-arm-msm,
	linux-kernel

The first two interconnects defined for IPA on the SDX55 SoC are
really two parts of what should be represented as a single path
between IPA and system memory.

Fix this by combining the "memory-a" and "memory-b" interconnects
into a single "memory" interconnect.

Reported-by: David Heidelberg <david@ixit.cz>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Alex Elder <elder@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 44526ad9d210b..eee2f63b9bbab 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -333,12 +333,10 @@ ipa: ipa@1e40000 {
 			clocks = <&rpmhcc RPMH_IPA_CLK>;
 			clock-names = "core";
 
-			interconnects = <&system_noc MASTER_IPA &system_noc SLAVE_SNOC_MEM_NOC_GC>,
-					<&mem_noc MASTER_SNOC_GC_MEM_NOC &mc_virt SLAVE_EBI_CH0>,
+			interconnects = <&system_noc MASTER_IPA &mc_virt SLAVE_EBI_CH0>,
 					<&system_noc MASTER_IPA &system_noc SLAVE_OCIMEM>,
 					<&mem_noc MASTER_AMPSS_M0 &system_noc SLAVE_IPA_CFG>;
-			interconnect-names = "memory-a",
-					     "memory-b",
+			interconnect-names = "memory",
 					     "imem",
 					     "config";
 
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH net-next 2/2] net: ipa: fix IPA v4.5 interconnect data
  2021-12-10 16:37 [PATCH net-next 0/2] net: ipa: fix SDX55 interconnects Alex Elder
  2021-12-10 16:37 ` [PATCH net-next 1/2] ARM: dts: qcom: sdx55: fix IPA interconnect definitions Alex Elder
@ 2021-12-10 16:37 ` Alex Elder
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2021-12-10 16:37 UTC (permalink / raw)
  To: davem, kuba
  Cc: david, manivannan.sadhasivam, jponduru, avuyyuru, bjorn.andersson,
	cpratapa, subashab, evgreen, elder, netdev, linux-arm-msm,
	linux-kernel

Update the definition of the IPA interconnects for IPA v4.5 so
the path between IPA and system memory is represented by a single
"memory" interconnect.

Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Alex Elder <elder@linaro.org>
---
 drivers/net/ipa/ipa_data-v4.5.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ipa/ipa_data-v4.5.c b/drivers/net/ipa/ipa_data-v4.5.c
index e62ab9c3ac672..2da2c4194f2e6 100644
--- a/drivers/net/ipa/ipa_data-v4.5.c
+++ b/drivers/net/ipa/ipa_data-v4.5.c
@@ -420,15 +420,10 @@ static const struct ipa_mem_data ipa_mem_data = {
 /* Interconnect rates are in 1000 byte/second units */
 static const struct ipa_interconnect_data ipa_interconnect_data[] = {
 	{
-		.name			= "memory-a",
+		.name			= "memory",
 		.peak_bandwidth		= 600000,	/* 600 MBps */
 		.average_bandwidth	= 150000,	/* 150 MBps */
 	},
-	{
-		.name			= "memory-b",
-		.peak_bandwidth		= 1804000,	/* 1.804 GBps */
-		.average_bandwidth	= 150000,	/* 150 MBps */
-	},
 	/* Average rate is unused for the next two interconnects */
 	{
 		.name			= "imem",
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-10 16:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-10 16:37 [PATCH net-next 0/2] net: ipa: fix SDX55 interconnects Alex Elder
2021-12-10 16:37 ` [PATCH net-next 1/2] ARM: dts: qcom: sdx55: fix IPA interconnect definitions Alex Elder
2021-12-10 16:37 ` [PATCH net-next 2/2] net: ipa: fix IPA v4.5 interconnect data Alex Elder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).