netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Cc: Ansuel Smith <ansuelsmth@gmail.com>
Subject: [net-next RFC PATCH v3 11/15] net: dsa: qca8k: add tracking state of master port
Date: Sat, 11 Dec 2021 03:01:48 +0100	[thread overview]
Message-ID: <20211211020155.10114-17-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20211211020155.10114-1-ansuelsmth@gmail.com>

MDIO/MIB Ethernet require the master port and the tagger availabale to
correctly work. Use the new api master_state_change to track when master
is operational or not and set a bool in qca8k_priv.
This bool will later be used by mdio read/write and mib request to
correctly use the working function.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 drivers/net/dsa/qca8k.c | 13 +++++++++++++
 drivers/net/dsa/qca8k.h |  1 +
 2 files changed, 14 insertions(+)

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 039694518788..905fae26e05b 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -2383,6 +2383,18 @@ qca8k_port_lag_leave(struct dsa_switch *ds, int port,
 	return qca8k_lag_refresh_portmap(ds, port, lag, true);
 }
 
+static void
+qca8k_master_change(struct dsa_switch *ds, const struct net_device *master,
+		    bool operational)
+{
+	struct qca8k_priv *priv = ds->priv;
+
+	if (operational)
+		priv->master_oper = true;
+	else
+		priv->master_oper = false;
+}
+
 static const struct dsa_switch_ops qca8k_switch_ops = {
 	.get_tag_protocol	= qca8k_get_tag_protocol,
 	.setup			= qca8k_setup,
@@ -2418,6 +2430,7 @@ static const struct dsa_switch_ops qca8k_switch_ops = {
 	.get_phy_flags		= qca8k_get_phy_flags,
 	.port_lag_join		= qca8k_port_lag_join,
 	.port_lag_leave		= qca8k_port_lag_leave,
+	.master_state_change	= qca8k_master_change,
 };
 
 static int qca8k_read_switch_id(struct qca8k_priv *priv)
diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h
index ab4a417b25a9..fb98536bf3e8 100644
--- a/drivers/net/dsa/qca8k.h
+++ b/drivers/net/dsa/qca8k.h
@@ -342,6 +342,7 @@ struct qca8k_priv {
 	u8 mirror_rx;
 	u8 mirror_tx;
 	u8 lag_hash_mode;
+	bool master_oper; /* Track if mdio/mib Ethernet is available */
 	bool legacy_phy_port_mapping;
 	struct qca8k_ports_config ports_config;
 	struct regmap *regmap;
-- 
2.32.0


  parent reply	other threads:[~2021-12-11  2:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-11  2:01 [net-next RFC PATCH v3 00/15] Add support for qca8k mdio rw in Ethernet packet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 01/15] net: dsa: provide switch operations for tracking the master state Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 02/15] net: dsa: stop updating master MTU from master.c Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 03/15] net: dsa: hold rtnl_mutex when calling dsa_master_{setup,teardown} Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 04/15] net: dsa: replay master state events in dsa_tree_{setup,teardown}_master Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 05/15] net: dsa: tag_qca: convert to FIELD macro Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 06/15] net: dsa: tag_qca: move define to include linux/dsa Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 07/15] net: da: tag_qca: enable promisc_on_master flag Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 07/14] net: dsa: tag_qca: add define for handling mdio Ethernet packet Ansuel Smith
2021-12-11 19:24   ` Vladimir Oltean
2021-12-11  2:01 ` [net-next RFC PATCH v3 08/14] net: dsa: tag_qca: add define for handling MIB packet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 08/15] net: dsa: tag_qca: add define for handling mdio Ethernet packet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 09/15] net: dsa: tag_qca: add define for handling MIB packet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 09/14] net: dsa: tag_qca: add support for handling mdio Ethernet and " Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 10/14] net: dsa: qca8k: add tracking state of master port Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 10/15] net: dsa: tag_qca: add support for handling mdio Ethernet and MIB packet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 11/14] net: dsa: qca8k: add support for mdio read/write in Ethernet packet Ansuel Smith
2021-12-11  2:01 ` Ansuel Smith [this message]
2021-12-11  2:01 ` [net-next RFC PATCH v3 12/15] " Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 12/14] net: dsa: qca8k: add support for mib autocast " Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 13/15] " Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 13/14] net: dsa: qca8k: add support for phy read/write with mdio Ethernet Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 14/15] " Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 14/14] net: dsa: qca8k: cache lo and hi for mdio write Ansuel Smith
2021-12-11  2:01 ` [net-next RFC PATCH v3 15/15] " Ansuel Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211211020155.10114-17-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=vivien.didelot@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).