From: Simon Horman <simon.horman@corigine.com>
To: Roi Dayan <roid@nvidia.com>
Cc: netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ido Schimmel <idosch@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>, Oz Shlomo <ozsh@nvidia.com>,
Vlad Buslov <vladbu@nvidia.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Louis Peens <louis.peens@corigine.com>,
oss-drivers@corigine.com
Subject: Re: [PATCH v6 net-next 04/12] flow_offload: return EOPNOTSUPP for the unsupported mpls action type
Date: Mon, 13 Dec 2021 15:49:56 +0100 [thread overview]
Message-ID: <20211213144955.GA24044@corigine.com> (raw)
In-Reply-To: <6e56aa1e-25a2-9bb7-aee3-6a2954216b73@nvidia.com>
On Sun, Dec 12, 2021 at 02:41:53PM +0200, Roi Dayan wrote:
>
>
> On 2021-12-09 11:27 AM, Simon Horman wrote:
> > From: Baowen Zheng <baowen.zheng@corigine.com>
> >
> > We need to return EOPNOTSUPP for the unsupported mpls action type when
> > setup the flow action.
> >
> > In the original implement, we will return 0 for the unsupported mpls
> > action type, actually we do not setup it and the following actions
> > to the flow action entry.
> >
> > Signed-off-by: Baowen Zheng <baowen.zheng@corigine.com>
> > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > ---
> > net/sched/cls_api.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> > index d9d6ff0bf361..7a680cae0bae 100644
> > --- a/net/sched/cls_api.c
> > +++ b/net/sched/cls_api.c
> > @@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
> > entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
> > break;
> > default:
> > + err = -EOPNOTSUPP;
> > goto err_out_locked;
> > }
> > } else if (is_tcf_skbedit_ptype(act)) {
>
> should we have this commit in net branch with a fixes line
> so it will be taken also to stable kernels?
>
> 6749d5901698 net: sched: include mpls actions in hardware intermediate
> representation
Thanks Roi,
I think that is a good idea and I have submitted the patch accordingly.
https://lore.kernel.org/netdev/20211213144604.23888-1-simon.horman@corigine.com/
FWIIW, I believe the problem was introduced by:
cba370a93684 ("flow_offload: return EOPNOTSUPP for the unsupported mpls action type")
next prev parent reply other threads:[~2021-12-13 14:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 9:27 [PATCH v6 net-next 00/12] allow user to offload tc action to net device Simon Horman
2021-12-09 9:27 ` [PATCH v6 net-next 01/12] flow_offload: fill flags to action structure Simon Horman
2021-12-11 19:05 ` Jamal Hadi Salim
2021-12-09 9:27 ` [PATCH v6 net-next 02/12] flow_offload: reject to offload tc actions in offload drivers Simon Horman
2021-12-11 19:07 ` Jamal Hadi Salim
2021-12-09 9:27 ` [PATCH v6 net-next 03/12] flow_offload: add index to flow_action_entry structure Simon Horman
2021-12-11 19:09 ` Jamal Hadi Salim
2021-12-12 8:41 ` Baowen Zheng
2021-12-09 9:27 ` [PATCH v6 net-next 04/12] flow_offload: return EOPNOTSUPP for the unsupported mpls action type Simon Horman
2021-12-11 19:10 ` Jamal Hadi Salim
2021-12-12 12:41 ` Roi Dayan
2021-12-13 14:49 ` Simon Horman [this message]
2021-12-09 9:27 ` [PATCH v6 net-next 05/12] flow_offload: add ops to tc_action_ops for flow action setup Simon Horman
2021-12-11 19:31 ` Jamal Hadi Salim
2021-12-12 8:52 ` Baowen Zheng
2021-12-09 9:28 ` [PATCH v6 net-next 06/12] flow_offload: allow user to offload tc action to net device Simon Horman
2021-12-11 19:42 ` Jamal Hadi Salim
2021-12-12 9:22 ` Baowen Zheng
2021-12-14 12:03 ` Jamal Hadi Salim
2021-12-09 9:28 ` [PATCH v6 net-next 07/12] flow_offload: add skip_hw and skip_sw to control if offload the action Simon Horman
2021-12-11 19:48 ` Jamal Hadi Salim
2021-12-16 13:50 ` [flow_offload] 42adbf37c1: kernel-selftests.tc-testing.d4cd.Add_skbedit_action_with_valid_mark_and_mask.fail kernel test robot
2021-12-17 8:32 ` Baowen Zheng
2021-12-09 9:28 ` [PATCH v6 net-next 08/12] flow_offload: add process to update action stats from hardware Simon Horman
2021-12-11 19:52 ` Jamal Hadi Salim
2021-12-12 9:00 ` Baowen Zheng
2021-12-14 12:01 ` Jamal Hadi Salim
2021-12-14 13:43 ` Baowen Zheng
2021-12-14 14:29 ` Jamal Hadi Salim
2021-12-09 9:28 ` [PATCH v6 net-next 09/12] net: sched: save full flags for tc action Simon Horman
2021-12-11 19:54 ` Jamal Hadi Salim
2021-12-09 9:28 ` [PATCH v6 net-next 10/12] flow_offload: add reoffload process to update hw_count Simon Horman
2021-12-09 9:28 ` [PATCH v6 net-next 11/12] flow_offload: validate flags of filter and actions Simon Horman
2021-12-11 19:55 ` Jamal Hadi Salim
2021-12-09 9:28 ` [PATCH v6 net-next 12/12] selftests: tc-testing: add action offload selftest for action and filter Simon Horman
2021-12-11 19:57 ` Jamal Hadi Salim
2021-12-12 9:04 ` Baowen Zheng
2021-12-09 10:41 ` [PATCH v6 net-next 00/12] allow user to offload tc action to net device Simon Horman
2021-12-11 19:04 ` Jamal Hadi Salim
2021-12-13 9:16 ` Simon Horman
2021-12-13 19:21 ` Vlad Buslov
2021-12-14 7:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213144955.GA24044@corigine.com \
--to=simon.horman@corigine.com \
--cc=baowen.zheng@corigine.com \
--cc=dan.carpenter@oracle.com \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=ozsh@nvidia.com \
--cc=roid@nvidia.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).