* [PATCH net] net: Fix double 0x prefix print in SKB dump
@ 2021-12-16 9:28 Gal Pressman
2021-12-16 20:51 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Gal Pressman @ 2021-12-16 9:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski; +Cc: netdev, Gal Pressman
When printing netdev features %pNF already takes care of the 0x prefix,
remove the explicit one.
Fixes: 6413139dfc64 ("skbuff: increase verbosity when dumping skb data")
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index a33247fdb8f5..275f7b8416fe 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -832,7 +832,7 @@ void skb_dump(const char *level, const struct sk_buff *skb, bool full_pkt)
ntohs(skb->protocol), skb->pkt_type, skb->skb_iif);
if (dev)
- printk("%sdev name=%s feat=0x%pNF\n",
+ printk("%sdev name=%s feat=%pNF\n",
level, dev->name, &dev->features);
if (sk)
printk("%ssk family=%hu type=%u proto=%u\n",
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: Fix double 0x prefix print in SKB dump
2021-12-16 9:28 [PATCH net] net: Fix double 0x prefix print in SKB dump Gal Pressman
@ 2021-12-16 20:51 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-16 20:51 UTC (permalink / raw)
To: Gal Pressman; +Cc: davem, kuba, netdev
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 16 Dec 2021 11:28:25 +0200 you wrote:
> When printing netdev features %pNF already takes care of the 0x prefix,
> remove the explicit one.
>
> Fixes: 6413139dfc64 ("skbuff: increase verbosity when dumping skb data")
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> ---
> net/core/skbuff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: Fix double 0x prefix print in SKB dump
https://git.kernel.org/netdev/net/c/8a03ef676ade
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-16 9:28 [PATCH net] net: Fix double 0x prefix print in SKB dump Gal Pressman
2021-12-16 20:51 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).