* [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i
@ 2021-12-24 6:48 Yu-Tung Chang
2021-12-24 7:03 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: Yu-Tung Chang @ 2021-12-24 6:48 UTC (permalink / raw)
To: tony0620emma
Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel,
Yu-Tung Chang
8821CE causes random freezes on HP Slim Desktop S01-pF1000i. Add a quirk
to disable pci ASPM capability.
Signed-off-by: Yu-Tung Chang <mtwget@gmail.com>
---
drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index a7a6ebfaa203..f8999d7dee61 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1738,6 +1738,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
},
.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
},
+ {
+ .callback = disable_pci_caps,
+ .ident = "HP HP Slim Desktop S01-pF1xxx",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP Slim Desktop S01-pF1xxx"),
+ },
+ .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
+ },
{}
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i
2021-12-24 6:48 [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i Yu-Tung Chang
@ 2021-12-24 7:03 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2021-12-24 7:03 UTC (permalink / raw)
To: Yu-Tung Chang, tony0620emma@gmail.com
Cc: kvalo@kernel.org, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Yu-Tung Chang <mtwget@gmail.com>
> Sent: Friday, December 24, 2021 2:49 PM
> To: tony0620emma@gmail.com
> Cc: kvalo@kernel.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yu-Tung Chang <mtwget@gmail.com>
> Subject: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i
>
> 8821CE causes random freezes on HP Slim Desktop S01-pF1000i. Add a quirk
> to disable pci ASPM capability.
>
> Signed-off-by: Yu-Tung Chang <mtwget@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index a7a6ebfaa203..f8999d7dee61 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1738,6 +1738,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
> },
> .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
> },
> + {
> + .callback = disable_pci_caps,
> + .ident = "HP HP Slim Desktop S01-pF1xxx",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Slim Desktop S01-pF1xxx"),
> + },
> + .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
> + },
> {}
> };
>
A patch [1] is merged to fix freezes of 8821ce.
[1] https://lore.kernel.org/all/20211215114635.333767-1-kai.heng.feng@canonical.com/
--
Ping-Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-24 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-24 6:48 [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i Yu-Tung Chang
2021-12-24 7:03 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).