From: menglong8.dong@gmail.com
To: rostedt@goodmis.org, dsahern@kernel.org
Cc: mingo@redhat.com, davem@davemloft.net, kuba@kernel.org,
nhorman@tuxdriver.com, edumazet@google.com,
yoshfuji@linux-ipv6.org, jonathan.lemon@gmail.com,
alobakin@pm.me, keescook@chromium.org, pabeni@redhat.com,
talalahmad@google.com, haokexin@gmail.com, imagedong@tencent.com,
atenart@kernel.org, bigeasy@linutronix.de, weiwan@google.com,
arnd@arndb.de, vvs@virtuozzo.com, cong.wang@bytedance.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
mengensun@tencent.com, mungerjiang@tencent.com
Subject: [PATCH v2 net-next 0/3] net: skb: introduce kfree_skb_with_reason() and use it for tcp and udp
Date: Thu, 30 Dec 2021 17:32:37 +0800 [thread overview]
Message-ID: <20211230093240.1125937-1-imagedong@tencent.com> (raw)
From: Menglong Dong <imagedong@tencent.com>
In this series patch, the interface kfree_skb_with_reason() is
introduced(), which is used to collect skb drop reason, and pass
it to 'kfree_skb' tracepoint. Therefor, 'drop_monitor' or eBPF is
able to monitor abnormal skb with detail reason.
In fact, this series patches are out of the intelligence of David
and Steve, I'm just a truck man :/
Previous discussion is here:
https://lore.kernel.org/netdev/20211118105752.1d46e990@gandalf.local.home/
https://lore.kernel.org/netdev/67b36bd8-2477-88ac-83a0-35a1eeaf40c9@gmail.com/
In the first patch, kfree_skb_with_reason() is introduced and
the 'reason' field is added to 'kfree_skb' tracepoint. In the
second patch, 'kfree_skb()' in replaced with 'kfree_skb_with_reason()'
in tcp_v4_rcv(). In the third patch, 'kfree_skb_with_reason()' is
used in __udp4_lib_rcv().
Changes since v1:
- rename some drop reason, as David suggested
- add the third patch
Menglong Dong (3):
net: skb: introduce kfree_skb_with_reason()
net: skb: use kfree_skb_with_reason() in tcp_v4_rcv()
net: skb: use kfree_skb_with_reason() in __udp4_lib_rcv()
include/linux/skbuff.h | 18 +++++++++++++++++
include/trace/events/skb.h | 41 +++++++++++++++++++++++++++++++-------
net/core/dev.c | 3 ++-
net/core/drop_monitor.c | 10 +++++++---
net/core/skbuff.c | 22 +++++++++++++++++++-
net/ipv4/tcp_ipv4.c | 14 ++++++++++---
net/ipv4/udp.c | 10 ++++++++--
7 files changed, 101 insertions(+), 17 deletions(-)
--
2.27.0
next reply other threads:[~2021-12-30 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 9:32 menglong8.dong [this message]
2021-12-30 9:32 ` [PATCH v2 net-next 1/3] net: skb: introduce kfree_skb_with_reason() menglong8.dong
2021-12-31 1:26 ` Jakub Kicinski
2021-12-31 6:35 ` Menglong Dong
2022-01-01 2:22 ` Jakub Kicinski
2021-12-30 9:32 ` [PATCH v2 net-next 2/3] net: skb: use kfree_skb_with_reason() in tcp_v4_rcv() menglong8.dong
2021-12-30 9:32 ` [PATCH net-next 3/3] net: skb: use kfree_skb_with_reason() in __udp4_lib_rcv() menglong8.dong
2022-01-04 1:47 ` [PATCH v2 net-next 0/3] net: skb: introduce kfree_skb_with_reason() and use it for tcp and udp Cong Wang
2022-01-04 2:01 ` David Ahern
2022-01-04 3:09 ` Cong Wang
2022-01-04 3:32 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230093240.1125937-1-imagedong@tencent.com \
--to=menglong8.dong@gmail.com \
--cc=alobakin@pm.me \
--cc=arnd@arndb.de \
--cc=atenart@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haokexin@gmail.com \
--cc=imagedong@tencent.com \
--cc=jonathan.lemon@gmail.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=mingo@redhat.com \
--cc=mungerjiang@tencent.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=vvs@virtuozzo.com \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).