From: David Ahern <dsahern@kernel.org>
To: netdev@vger.kernel.org
Cc: idosch@idosch.org, David Ahern <dsahern@kernel.org>,
Roopa Prabhu <roopa@nvidia.com>
Subject: [PATCH net 4/5] ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route
Date: Thu, 30 Dec 2021 17:36:34 -0700 [thread overview]
Message-ID: <20211231003635.91219-5-dsahern@kernel.org> (raw)
In-Reply-To: <20211231003635.91219-1-dsahern@kernel.org>
Make sure RTA_GATEWAY for IPv6 multipath route has enough bytes to hold
an IPv6 address.
Fixes: 6b9ea5a64ed5 ("ipv6: fix multipath route replace error recovery")
Signed-off-by: David Ahern <dsahern@kernel.org>
Cc: Roopa Prabhu <roopa@nvidia.com>
---
net/ipv6/route.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d16599c225b8..b311c0bc9983 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -5453,7 +5453,11 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
nla = nla_find(attrs, attrlen, RTA_GATEWAY);
if (nla) {
- nla_memcpy(&r_cfg.fc_gateway, nla, 16);
+ err = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
+ extack);
+ if (err)
+ return err;
+
r_cfg.fc_flags |= RTF_GATEWAY;
}
}
--
2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-12-31 0:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 0:36 [PATCH net 0/5] net: Length checks for attributes within multipath routes David Ahern
2021-12-31 0:36 ` [PATCH net 1/5] ipv4: Check attribute length for RTA_GATEWAY in multipath route David Ahern
2021-12-31 0:36 ` [PATCH net 2/5] ipv4: Check attribute length for RTA_FLOW " David Ahern
2021-12-31 0:36 ` [PATCH net 3/5] ipv6: Check attribute length for RTA_GATEWAY " David Ahern
2021-12-31 15:30 ` Nicolas Dichtel
2022-01-02 16:45 ` David Ahern
2021-12-31 0:36 ` David Ahern [this message]
2021-12-31 15:51 ` [PATCH net 4/5] ipv6: Check attribute length for RTA_GATEWAY when deleting " Nicolas Dichtel
2021-12-31 0:36 ` [PATCH net 5/5] lwtunnel: Validate RTA_ENCAP_TYPE attribute length David Ahern
2021-12-31 14:40 ` [PATCH net 0/5] net: Length checks for attributes within multipath routes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211231003635.91219-5-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).