[PATCH net-next] net: vertexcom: default to disabled on kbuild

[PATCH net-next] net: vertexcom: default to disabled on kbuild

[Saeed Mahameed]

From: Saeed Mahameed <saeedm@nvidia.com>

Sorry for being rude but new vendors/drivers are supposed to be disabled
by default, otherwise we will have to manually keep track of all vendors
we are not interested in building.

Fixes: 2f207cbf0dd4 ("net: vertexcom: Add MSE102x SPI support")
CC: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/vertexcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/vertexcom/Kconfig b/drivers/net/ethernet/vertexcom/Kconfig
index 4184a635fe01..6e2cf062ddba 100644
--- a/drivers/net/ethernet/vertexcom/Kconfig
+++ b/drivers/net/ethernet/vertexcom/Kconfig
@@ -5,7 +5,7 @@
 
 config NET_VENDOR_VERTEXCOM
 	bool "Vertexcom devices"
-	default y
+	default n
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
-- 
2.33.1

Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Sun,  2 Jan 2022 14:11:26 -0800 you wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> Sorry for being rude but new vendors/drivers are supposed to be disabled
> by default, otherwise we will have to manually keep track of all vendors
> we are not interested in building.
> 
> Fixes: 2f207cbf0dd4 ("net: vertexcom: Add MSE102x SPI support")
> CC: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: vertexcom: default to disabled on kbuild
    https://git.kernel.org/netdev/net-next/c/6bf950a8ff72

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild

[Jakub Kicinski]

On Sun,  2 Jan 2022 14:11:26 -0800 Saeed Mahameed wrote:
> Sorry for being rude but new vendors/drivers are supposed to be disabled
> by default, otherwise we will have to manually keep track of all vendors
> we are not interested in building.

Vendors default to y, drivers default to n. Vendors don't build
anything, hence the somewhat unusual convention. Are you saying
you want to change all the Kconfigs... including Mellanox?

Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild

[Saeed Mahameed]

On Mon, Jan 03, 2022 at 08:43:21AM -0800, Jakub Kicinski wrote:
>On Sun,  2 Jan 2022 14:11:26 -0800 Saeed Mahameed wrote:
>> Sorry for being rude but new vendors/drivers are supposed to be disabled
>> by default, otherwise we will have to manually keep track of all vendors
>> we are not interested in building.
>
>Vendors default to y, drivers default to n. Vendors don't build
>anything, hence the somewhat unusual convention. Are you saying
>you want to change all the Kconfigs... including Mellanox?

I didn't know about the vendor vs drivers thing! What's the point ? :) 
Now as i think about it, Yes, why not change all vendors including Mellanox? 
I don't see any point to visit a sub-tree where nothing is going to build,
and waste a chunk of precious build time.

Anyhow, I can add the default 'n' to the driver and revert the
vendor back to 'y', Please let me know if you'd want that.

Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild

[Jakub Kicinski]

On Tue, 4 Jan 2022 00:25:55 -0800 Saeed Mahameed wrote:
> On Mon, Jan 03, 2022 at 08:43:21AM -0800, Jakub Kicinski wrote:
> >On Sun,  2 Jan 2022 14:11:26 -0800 Saeed Mahameed wrote:  
> >> Sorry for being rude but new vendors/drivers are supposed to be disabled
> >> by default, otherwise we will have to manually keep track of all vendors
> >> we are not interested in building.  
> >
> >Vendors default to y, drivers default to n. Vendors don't build
> >anything, hence the somewhat unusual convention. Are you saying
> >you want to change all the Kconfigs... including Mellanox?  
> 
> I didn't know about the vendor vs drivers thing! What's the point ? :) 
> Now as i think about it, Yes, why not change all vendors including Mellanox? 
> I don't see any point to visit a sub-tree where nothing is going to build,
> and waste a chunk of precious build time.
> 
> Anyhow, I can add the default 'n' to the driver and revert the
> vendor back to 'y', Please let me know if you'd want that.

I'm not sure what the origins of the convention are. Maybe when 
the Ethernet drivers got split by vendor we were concerned that 
if we default vendors to n someone doing olddefconfig will lose
drivers?

In any case, my weak preference is also to abandon the convention
unless someone can point out why it's good/useful. The fewer rules 
the better.

FWIW I think that if there is no default set explicitly in Kconfig
it will default to n so if you're writing the patch - you can remove
the overrides rather than setting them to n.

Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild

[Leon Romanovsky]

On Mon, Jan 03, 2022 at 08:43:21AM -0800, Jakub Kicinski wrote:
> On Sun,  2 Jan 2022 14:11:26 -0800 Saeed Mahameed wrote:
> > Sorry for being rude but new vendors/drivers are supposed to be disabled
> > by default, otherwise we will have to manually keep track of all vendors
> > we are not interested in building.
> 
> Vendors default to y, drivers default to n. Vendors don't build
> anything, hence the somewhat unusual convention. Are you saying
> you want to change all the Kconfigs... including Mellanox?

I would love to see such patch. It will help me to manage build configs
to their minimum without worrying to press "N" every time I switch from
builds of net-next to any other tree without newly introduced vendor.

https://lore.kernel.org/netdev/20200930095526.GM3094@unreal/
https://lore.kernel.org/netdev/20200930104459.GO3094@unreal/

And yes, including Mellanox.

Thanks