Netdev List
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH net-next] net: vertexcom: default to disabled on kbuild
Date: Tue, 4 Jan 2022 00:25:55 -0800	[thread overview]
Message-ID: <20220104082555.s2ngia5hqvupplzi@sx1> (raw)
In-Reply-To: <20220103084321.48236cfa@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

On Mon, Jan 03, 2022 at 08:43:21AM -0800, Jakub Kicinski wrote:
>On Sun,  2 Jan 2022 14:11:26 -0800 Saeed Mahameed wrote:
>> Sorry for being rude but new vendors/drivers are supposed to be disabled
>> by default, otherwise we will have to manually keep track of all vendors
>> we are not interested in building.
>
>Vendors default to y, drivers default to n. Vendors don't build
>anything, hence the somewhat unusual convention. Are you saying
>you want to change all the Kconfigs... including Mellanox?

I didn't know about the vendor vs drivers thing! What's the point ? :) 
Now as i think about it, Yes, why not change all vendors including Mellanox? 
I don't see any point to visit a sub-tree where nothing is going to build,
and waste a chunk of precious build time.

Anyhow, I can add the default 'n' to the driver and revert the
vendor back to 'y', Please let me know if you'd want that.



  reply	other threads:[~2022-01-04  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-02 22:11 [PATCH net-next] net: vertexcom: default to disabled on kbuild Saeed Mahameed
2022-01-03 10:50 ` patchwork-bot+netdevbpf
2022-01-03 16:43 ` Jakub Kicinski
2022-01-04  8:25   ` Saeed Mahameed [this message]
2022-01-04 15:15     ` Jakub Kicinski
2022-01-04  8:57   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220104082555.s2ngia5hqvupplzi@sx1 \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox