From: Saeed Mahameed <saeed@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover()
Date: Wed, 5 Jan 2022 19:51:37 -0800 [thread overview]
Message-ID: <20220106035137.wwfpxejblgbpw66w@sx1> (raw)
In-Reply-To: <20220105151751.40723-1-jiapeng.chong@linux.alibaba.com>
On Wed, Jan 05, 2022 at 11:17:51PM +0800, Jiapeng Chong wrote:
>The error code is missing in this code scenario, add the error code
>'-EINVAL' to the return value 'err'.
>
>Eliminate the follow smatch warning:
>
>drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c:91
>mlx5e_rx_reporter_err_icosq_cqe_recover() warn: missing error code
>'err'.
>
error code is not missing, err is equal to 0 at this point and the
code aborts with err = 0 as intended. False alarm. nack.
prev parent reply other threads:[~2022-01-06 3:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 15:17 [PATCH] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover() Jiapeng Chong
2022-01-06 3:51 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106035137.wwfpxejblgbpw66w@sx1 \
--to=saeed@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox