* [PATCH v2] tracing: check the return value of kstrdup()
@ 2021-12-14 1:28 xkernel.wang
2022-01-05 22:10 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: xkernel.wang @ 2021-12-14 1:28 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, netdev, bpf, Xiaoke Wang
From: Xiaoke Wang <xkernel.wang@foxmail.com>
kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it so to catch the memory error in
time.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
Changelogs:
Compare with the last email, this one is using my full name.
And I am sorry that I did not notice the bugs in trace_boot.c had been
already patched. So I removed the content about trace_boot.c.
---
kernel/trace/trace_uprobe.c | 5 +++++
1 files changed, 5 insertions(+)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 225ce56..173ff0f 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
tu->path = path;
tu->ref_ctr_offset = ref_ctr_offset;
tu->filename = kstrdup(name, GFP_KERNEL);
+ if (!tu->filename) {
+ ret = -ENOMEM;
+ goto error;
+ }
+
init_trace_event_call(tu);
ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tracing: check the return value of kstrdup()
2021-12-14 1:28 [PATCH v2] tracing: check the return value of kstrdup() xkernel.wang
@ 2022-01-05 22:10 ` Steven Rostedt
2022-01-05 22:35 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2022-01-05 22:10 UTC (permalink / raw)
To: xkernel.wang; +Cc: mingo, linux-kernel, netdev, bpf, Masami Hiramatsu
Masami, can you ack this ?
-- Steve
On Tue, 14 Dec 2021 09:28:02 +0800
xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrdup() returns NULL when some internal memory errors happen, it is
> better to check the return value of it so to catch the memory error in
> time.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> Changelogs:
> Compare with the last email, this one is using my full name.
> And I am sorry that I did not notice the bugs in trace_boot.c had been
> already patched. So I removed the content about trace_boot.c.
> ---
> kernel/trace/trace_uprobe.c | 5 +++++
> 1 files changed, 5 insertions(+)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 225ce56..173ff0f 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
> tu->path = path;
> tu->ref_ctr_offset = ref_ctr_offset;
> tu->filename = kstrdup(name, GFP_KERNEL);
> + if (!tu->filename) {
> + ret = -ENOMEM;
> + goto error;
> + }
> +
> init_trace_event_call(tu);
>
> ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tracing: check the return value of kstrdup()
2022-01-05 22:10 ` Steven Rostedt
@ 2022-01-05 22:35 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2022-01-05 22:35 UTC (permalink / raw)
To: Steven Rostedt
Cc: xkernel.wang, mingo, linux-kernel, netdev, bpf, Masami Hiramatsu
On Wed, 5 Jan 2022 17:10:49 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> Masami, can you ack this ?
Yes, this is actual bug. Thanks for fixing!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: 33ea4b24277b ("perf/core: Implement the 'perf_uprobe' PMU")
>
> -- Steve
>
>
> On Tue, 14 Dec 2021 09:28:02 +0800
> xkernel.wang@foxmail.com wrote:
>
> > From: Xiaoke Wang <xkernel.wang@foxmail.com>
> >
> > kstrdup() returns NULL when some internal memory errors happen, it is
> > better to check the return value of it so to catch the memory error in
> > time.
> >
> > Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> > ---
> > Changelogs:
> > Compare with the last email, this one is using my full name.
> > And I am sorry that I did not notice the bugs in trace_boot.c had been
> > already patched. So I removed the content about trace_boot.c.
> > ---
> > kernel/trace/trace_uprobe.c | 5 +++++
> > 1 files changed, 5 insertions(+)
> >
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index 225ce56..173ff0f 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
> > tu->path = path;
> > tu->ref_ctr_offset = ref_ctr_offset;
> > tu->filename = kstrdup(name, GFP_KERNEL);
> > + if (!tu->filename) {
> > + ret = -ENOMEM;
> > + goto error;
> > + }
> > +
> > init_trace_event_call(tu);
> >
> > ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 22:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14 1:28 [PATCH v2] tracing: check the return value of kstrdup() xkernel.wang
2022-01-05 22:10 ` Steven Rostedt
2022-01-05 22:35 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).