netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arthur Kiyanovski <akiyano@amazon.com>
To: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: Arthur Kiyanovski <akiyano@amazon.com>,
	"Woodhouse, David" <dwmw@amazon.com>,
	"Machulsky, Zorik" <zorik@amazon.com>,
	"Matushevsky, Alexander" <matua@amazon.com>,
	Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
	"Liguori, Anthony" <aliguori@amazon.com>,
	"Bshara, Nafea" <nafea@amazon.com>,
	"Belgazal, Netanel" <netanel@amazon.com>,
	"Saidi, Ali" <alisaidi@amazon.com>,
	"Herrenschmidt, Benjamin" <benh@amazon.com>,
	"Dagan, Noam" <ndagan@amazon.com>,
	"Agroskin, Shay" <shayagr@amazon.com>,
	"Arinzon, David" <darinzon@amazon.com>
Subject: [PATCH V2 net-next 06/10] net: ena: Move reset completion print to the reset function
Date: Fri, 7 Jan 2022 20:23:42 +0000	[thread overview]
Message-ID: <20220107202346.3522-7-akiyano@amazon.com> (raw)
In-Reply-To: <20220107202346.3522-1-akiyano@amazon.com>

The print that indicates that device reset has finished is
currently called from ena_restore_device().

Move it to ena_fw_reset_device() as it is the more natural
location for it.

Signed-off-by: Shay Agroskin <shayagr@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 2dfb1ee378e5..b4e10f7082e2 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -3654,8 +3654,6 @@ static int ena_restore_device(struct ena_adapter *adapter)
 	mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
 	adapter->last_keep_alive_jiffies = jiffies;
 
-	dev_err(&pdev->dev, "Device reset completed successfully\n");
-
 	return rc;
 err_disable_msix:
 	ena_free_mgmnt_irq(adapter);
@@ -3685,6 +3683,8 @@ static void ena_fw_reset_device(struct work_struct *work)
 	if (likely(test_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags))) {
 		ena_destroy_device(adapter, false);
 		ena_restore_device(adapter);
+
+		dev_err(&adapter->pdev->dev, "Device reset completed successfully\n");
 	}
 
 	rtnl_unlock();
-- 
2.32.0


  parent reply	other threads:[~2022-01-07 20:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 20:23 [PATCH V2 net-next 00/10] ENA: capabilities field and cosmetic changes Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 01/10] net: ena: Change return value of ena_calc_io_queue_size() to void Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 02/10] net: ena: Add capabilities field with support for ENI stats capability Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 03/10] net: ena: Change ENI stats support check to use capabilities field Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 04/10] net: ena: Update LLQ header length in ena documentation Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 05/10] net: ena: Remove redundant return code check Arthur Kiyanovski
2022-01-07 20:23 ` Arthur Kiyanovski [this message]
2022-01-07 20:23 ` [PATCH V2 net-next 07/10] net: ena: Remove ena_calc_queue_size_ctx struct Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 08/10] net: ena: Add debug prints for invalid req_id resets Arthur Kiyanovski
2022-01-07 20:23 ` [PATCH V2 net-next 09/10] net: ena: Change the name of bad_csum variable Arthur Kiyanovski
2022-01-08  3:27   ` Jakub Kicinski
2022-01-07 20:23 ` [PATCH V2 net-next 10/10] net: ena: Extract recurring driver reset code into a function Arthur Kiyanovski
2022-01-08  3:30 ` [PATCH V2 net-next 00/10] ENA: capabilities field and cosmetic changes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107202346.3522-7-akiyano@amazon.com \
    --to=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=darinzon@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.com \
    --cc=kuba@kernel.org \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=shayagr@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).